Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Collection thumbnail bug #886

Open
1 task
ShanaLMoore opened this issue Nov 11, 2024 · 3 comments
Open
1 task

Default Collection thumbnail bug #886

ShanaLMoore opened this issue Nov 11, 2024 · 3 comments
Assignees
@ShanaLMoore
Labels
cutover bug reindex

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Nov 11, 2024 •
edited
Loading

Summary

The default collection thumbnail is set to a different image than what is displaying

Image

Image

inspect tool:

Image

Acceptance Criteria

  • Collections without thumbnails should use the default image set in the settings, if one exists

Testing Instructions

NOTE: You may have to reindex works and collections for changes to take

In the Admin Dashboard, go to settings > Appearance > Default Image
If a collection image is not uploaded here, upload one an save.
Create a new or edit a collection with no thumbnail and save.
Go to the collections index page. The thumbnail should reflect the chosen default image.

Notes
@ShanaLMoore ShanaLMoore added bug something isn't working cutover bug and removed bug something isn't working labels Nov 11, 2024
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Nov 13, 2024 •
edited
Loading

I am able to reproduce this issue locally and is a bug in Hyku

@ShanaLMoore
Copy link
Contributor Author

related:

@ShanaLMoore ShanaLMoore self-assigned this Nov 13, 2024
@ShanaLMoore ShanaLMoore moved this to In Development in Adventist Knapsack Nov 13, 2024
ShanaLMoore added a commit to samvera/hyku that referenced this issue Nov 13, 2024
@ShanaLMoore
[i886] - update logic to fix collection thumbnail bug
50043e7 
The default work thumbnail was displaying even though the default collection thumbnail was set.

Issue:
- scientist-softserv/adventist_knapsack#886
@ShanaLMoore ShanaLMoore mentioned this issue Nov 13, 2024
Merged
3 tasks
ShanaLMoore added a commit to samvera/hyku that referenced this issue Nov 14, 2024
@ShanaLMoore
[i886] - Fix collection thumbnail fallback logic in Hyrax::ThumbnailP…
7e77eb6 
…athServiceDecorator

The default work thumbnail was displaying even though the default collection thumbnail was set.

Issue:
- scientist-softserv/adventist_knapsack#886

- Updated #call method to use default_collection_image for collection resources when thumbnail_id is blank.
- Ensures collections without specific thumbnails use the site-wide default collection image instead of the default work image.
- Improved fallback logic to distinguish between collections and works, avoiding issues with collections displaying the work default image.
@jillpe jillpe moved this from In Development to Code Review in Adventist Knapsack Nov 14, 2024
ShanaLMoore added a commit that referenced this issue Nov 14, 2024
@ShanaLMoore
Update hyku to pull in default collection thumbnail fix
32322e2 
Issue:
- #886
@ShanaLMoore ShanaLMoore mentioned this issue Nov 14, 2024
Merged
3 tasks
ShanaLMoore added a commit that referenced this issue Nov 15, 2024
@ShanaLMoore
Update hyku to pull in default collection thumbnail fix (#891)
cd10a71 
Issue:
- #886

ref: 
- HYKU: samvera/hyku#2381

# When No Collection Branding is Set

## When Default Collection Thumbnail is Set
- [ ] Collections should render the default thumbnail

![Screenshot 2024-11-13 at 13-49-38 Show Appearance __
Hyku](https://github.com/user-attachments/assets/e569edc4-4ae7-4117-bd2c-86259054aab1)

![Screenshot 2024-11-13 at 13-50-18
Collections](https://github.com/user-attachments/assets/58f5a5eb-e693-4afc-aa43-a02d21e47b71)


## When Default Collection Thumbnail is NOT set
- [ ] Collections should render Hyrax's default thumbnail

![Screenshot 2024-11-13 at 13-50-54 Show Appearance __
Hyku](https://github.com/user-attachments/assets/29a74933-c7f1-40b5-b20d-a46fe28bd1da)


![Screenshot 2024-11-13 at 13-51-05
Collections](https://github.com/user-attachments/assets/ce945c3b-41c8-4a4d-b22b-6e5fd79dddce)



# When Collection Branding is Set

## When Default Collection Thumbnail is Set
- [ ] Collections should render the Branding thumbnail

![Screenshot 2024-11-13 at 13-50-37 Edit User Collection es __
Hyku](https://github.com/user-attachments/assets/78569507-1f36-4c99-8879-fd391b4929f6)



![Screenshot 2024-11-13 at 15-40-53
Collections](https://github.com/user-attachments/assets/fe0b7100-0404-43b1-a074-d26fa4f3fea9)
@laritakr
Copy link
Contributor

QA Results: ✅ Pass

After reindexing a collection (via edit/save) that was using the work's default image, it now shows the tenant's default image.

https://adl.s2.adventistdigitallibrary.org/collections/232b5307-e19a-409a-a296-6fa194b3902c?locale=en

@laritakr laritakr moved this from Code Review to Client QA in Adventist Knapsack Nov 15, 2024
@jillpe jillpe moved this from Client QA to Deploy to Production in Adventist Knapsack Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShanaLMoore ShanaLMoore

Labels
cutover bug reindex
Projects
Adventist Knapsack
Status: Deploy to Production
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ShanaLMoore @laritakr