🧹 Remove spec/models/role_spec.rb #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The knapsack tests of `spec/models/role_spec.rb` is a subset of the tests in `hyrax-webapp/spec/models/role_spec.rb` As such, we can fully remove those tests. To further check, I copied over the Hyku version ran the spec; they all passed. So we can now defer to Hyku on these tests. Related to: - https://github.com/scientist-softserv/adventist-dl/issues/538
kirkkwang
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The knapsack tests of
spec/models/role_spec.rbis a subset of thetests in
hyrax-webapp/spec/models/role_spec.rbAs such, we can fully remove those tests. To further check, I copied
over the Hyku version ran the spec; they all passed. So we can now
defer to Hyku on these tests.
Related to: