From 86a57da9253c5d95d436f678e2e7fa98ca18921a Mon Sep 17 00:00:00 2001
From: Kirk Wang <kirk.wang@scientist.com>
Date: Mon, 23 Sep 2024 10:04:53 -0700
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Update=20catalog=20search=20to?=
 =?UTF-8?q?=20fix=20discrepancies?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This commit will update the deprecated link_to_search to link_to_facet
which will enable the faceted properties on each search hit to be a
link.

Ref:
- https://github.com/scientist-softserv/adventist_knapsack/issues/759
---
 hyrax-webapp                                  |  2 +-
 .../property_mappings/property_mappings.rb    | 28 +++++++++----------
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/hyrax-webapp b/hyrax-webapp
index b193a393..394fc042 160000
--- a/hyrax-webapp
+++ b/hyrax-webapp
@@ -1 +1 @@
-Subproject commit b193a393d7ec971bf55dff73910f805912024667
+Subproject commit 394fc0427db8cfe926a8dd5b3495d66b8f1ecfe8
diff --git a/lib/dog_biscuits/property_mappings/property_mappings.rb b/lib/dog_biscuits/property_mappings/property_mappings.rb
index b44ccb3c..9d468a7c 100644
--- a/lib/dog_biscuits/property_mappings/property_mappings.rb
+++ b/lib/dog_biscuits/property_mappings/property_mappings.rb
@@ -13,8 +13,8 @@ module PropertyMappings
     #   label: a human-readable label for the property REQUIRED
     #   index: any additional options for the blacklight index in an array
     #     excluding helper_method and item prop
-    #     provide in a hash, eg. [{ if: false }], or [{ link_to_search: true }]
-    #     nb. for link_to_search, just provide true
+    #     provide in a hash, eg. [{ if: false }], or [{ link_to_facet: true }]
+    #     nb. for link_to_facet, just provide true
     #   schema_org: hash containing property; can also include type and value
     #   help_text: help text to include in the form
     #   render_as: a custom renderer for the field (omit facetable)
@@ -26,7 +26,7 @@ def property_mappings
         {
           file_format: {
             label: 'File format',
-            index: [{ link_to_search: true }]
+            index: [{ link_to_facet: true }]
           },
           embargo_release_date: {
             label: 'Embargo releases on',
@@ -84,11 +84,11 @@ def property_mappings
             label: 'Altitude'
           },
           awarding_institution: {
-            index: [{ link_to_search: true }],
+            index: [{ link_to_facet: true }],
             label: 'Awarding institution'
           },
           based_near: {
-            index: [{ link_to_search: true }],
+            index: [{ link_to_facet: true }],
             schema_org: {
               property: "contentLocation",
               type: "http://schema.org/Place",
@@ -98,7 +98,7 @@ def property_mappings
             help_text: "A place name related to the work, such as its site of publication, or the city, state, or country the work contents are about. Calls upon the <a href='http://www.geonames.org'>GeoNames web service</a>."
           },
           based_near_label: {
-            index: [{ link_to_search: true }],
+            index: [{ link_to_facet: true }],
             schema_org: {
               property: "contentLocation",
               type: "http://schema.org/Place",
@@ -111,7 +111,7 @@ def property_mappings
             help_text: "The version of the file, eg. Author's Original or Accepted Manuscript."
           },
           contributor: {
-            index: [{ link_to_search: true }],
+            index: [{ link_to_facet: true }],
             schema_org: {
               property: "contributor",
               type: "http://schema.org/Person",
@@ -121,7 +121,7 @@ def property_mappings
             help_text: "A person or group you want to recognize for playing a role in the creation of the work, but not the primary role."
           },
           contributor_combined: {
-            index: [{ link_to_search: true }],
+            index: [{ link_to_facet: true }],
             schema_org: {
               property: "contributor",
               type: "http://schema.org/Person",
@@ -133,7 +133,7 @@ def property_mappings
             label: 'Contributor type'
           },
           creator: {
-            index: [{ link_to_search: true }],
+            index: [{ link_to_facet: true }],
             label: 'Creator',
             schema_org: {
               property: "creator",
@@ -297,7 +297,7 @@ def property_mappings
             label: 'Journal name'
           },
           keyword: {
-            index: [{ link_to_search: true }],
+            index: [{ link_to_facet: true }],
             label: 'Keywords',
             schema_org: {
               property: "keywords"
@@ -305,7 +305,7 @@ def property_mappings
             help_text: "Words or phrases you select to describe what the work is about. These are used to search for content."
           },
           language: {
-            index: [{ link_to_search: true }],
+            index: [{ link_to_facet: true }],
             label: 'Language',
             schema_org: {
               property: "language"
@@ -417,7 +417,7 @@ def property_mappings
             helper_method: 'publication_status'
           },
           publisher: {
-            index: [{ link_to_search: true }],
+            index: [{ link_to_facet: true }],
             schema_org: {
               property: "publisher",
               type: "http://schema.org/Organization",
@@ -444,7 +444,7 @@ def property_mappings
             label: 'Related URL'
           },
           resource_type: {
-            index: [{ link_to_search: true }],
+            index: [{ link_to_facet: true }],
             schema_org: {
               'Article' => "http://schema.org/Article",
               'Audio' => "http://schema.org/AudioObject",
@@ -501,7 +501,7 @@ def property_mappings
             label: 'Source'
           },
           subject: {
-            index: [{ link_to_search: true }],
+            index: [{ link_to_facet: true }],
             schema_org: {
               property: "about",
               type: "http://schema.org/Thing",