Skip to content

Commit

Permalink
fix: small updates from repo-review (#537)
Browse files Browse the repository at this point in the history
Some small things noticed while working on sp-repo-review.
scientific-python/cookie#299 and
scientific-python/cookie#300 and
scientific-python/repo-review#152.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
  • Loading branch information
henryiii authored Oct 25, 2023
1 parent b063c2d commit 9ac2e35
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.1.2
hooks:
- id: ruff-format
- id: ruff
args: ["--fix", "--show-fixes"]
- id: ruff-format

- repo: https://github.com/pre-commit/pygrep-hooks
rev: v1.10.0
Expand All @@ -35,7 +35,7 @@ repos:
- id: rst-directive-colons
- id: rst-inline-touching-normal

- repo: https://github.com/asottile/blacken-docs
- repo: https://github.com/adamchainz/blacken-docs
rev: 1.16.0
hooks:
- id: blacken-docs
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ report.exclude_lines = [
ignore = ["W002"] # Triggers on __init__.py's

[tool.ruff]
typing-modules = ["scikit_build_core._compat.typing"]
src = ["src"]
exclude = []

Expand Down Expand Up @@ -237,7 +236,7 @@ select = [
"FBT", # flake8-boolean-trap
"PYI", # flake8-pyi
]
extend-ignore = [
ignore = [
"PLR", # Design rules for pylint
"PLE1205", # Format check doesn't work with our custom logger
"E501", # Line too long
Expand All @@ -246,6 +245,7 @@ extend-ignore = [
"PYI025", # Wants Set to be renamed AbstractSet
]
unfixable = ["T20", "F841"]
typing-modules = ["scikit_build_core._compat.typing"]

[tool.ruff.lint.flake8-tidy-imports.banned-api]
"typing.Callable".msg = "Use collections.abc.Callable instead."
Expand Down

0 comments on commit 9ac2e35

Please sign in to comment.