Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to Ruff-format #2777

Merged
merged 2 commits into from
Oct 27, 2023
Merged

chore: move to Ruff-format #2777

merged 2 commits into from
Oct 27, 2023

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Oct 26, 2023

This moves to Ruff-format. Most changes are better (and the one that's worse is being fixed, see astral-sh/ruff#8226).

I've also removed a few checks that were redundant (pyupgrade) or slow and not very helpful / probably redundant (check debug statements).

An uncached run of black took 4.63s. With caching it's 0.4s. Ruff-format doesn't have caching yet AFAIK, but it takes 0.06 seconds.

Dropping pyupgrade saves 2 more seconds. Debug statements saves another 0.5 seconds.

Total time is now under 4 seconds for me. It used to be 6.5-10 seconds.

See scientific-python/cookie#299.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #2777 (47c3b49) into main (e8072ce) will increase coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
Files Coverage Δ
src/awkward/_connect/numba/arrayview.py 93.73% <ø> (+0.36%) ⬆️
src/awkward/contents/regulararray.py 85.14% <100.00%> (ø)
src/awkward/operations/ak_concatenate.py 96.29% <ø> (ø)

... and 3 files with indirect coverage changes

@henryiii henryiii temporarily deployed to docs October 26, 2023 15:36 — with GitHub Actions Inactive
src/awkward/_typing.py Outdated Show resolved Hide resolved
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@agoose77 agoose77 merged commit a79b9ad into main Oct 27, 2023
37 checks passed
@agoose77 agoose77 deleted the henryiii/fix/ruffformat branch October 27, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants