fix: (better) error when filling an int with a float #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/fix/int
branch
from
c3cada0
to
a14c99f
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
changed the title
matthewfeickert
added a commit
to scikit-hep/hist
that referenced
this pull request
Sep 13, 2023
* Use the same information as provided by boost-histogram in scikit-hep/boost-histogram#876
henryiii
pushed a commit
to scikit-hep/hist
that referenced
this pull request
Sep 13, 2023
* Use the same information as provided by boost-histogram in scikit-hep/boost-histogram#876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #843.
Currently, only single fills error when using a float on an int axis - this expands the error to arrays too. It's important to error since
-.9and.9both become 0 when converting from floats to ints. And explicit is better than implicit.