-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of mypy's # type: ignore[unreachable]
comments
#221
Labels
help wanted
Extra attention is needed
Comments
#89 removes |
I guess the issue here is that Momentum is a subclass of VectorProtocol, while Vector2D, Vector3D etc. are also subclasses. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now
mypy
throws a bunch of errors in this particular code block -vector/src/vector/backends/awkward.py
Lines 575 to 582 in 02d4655
saying -
These errors have been suppressed using the
type: ignore[unreachable]
comments, but this should be fixed. Thetype: ignore[unreachable]
comments should be removed fromVector
(these are the onlytype: ignore[unreachable]
comments left in the codebase).The text was updated successfully, but these errors were encountered: