-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version support/assetdatabase #31
base: dev
Are you sure you want to change the base?
Version support/assetdatabase #31
Conversation
…le to filter TableDumpSpecs based on DBVersion compatibility
@@ -48,7 +48,7 @@ internal static IReadOnlyList<Process> FindUnityProcessesForProject(NPath projec | |||
|
|||
foreach (var unityProcess in Process.GetProcessesByName(UnityConstants.UnityProcessName)) | |||
{ | |||
var workingDir = NativeWindows.SafeGetProcessCurrentDirectory(unityProcess.Id)?.ToNPath(); | |||
var workingDir = "";//NativeWindows.SafeGetProcessCurrentDirectory(unityProcess.Id)?.ToNPath(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look temporarily commented out, is that right?
@@ -94,7 +94,7 @@ public void DumpTable(DumpContext dump, AssetLmdb db, TableDumpSpec spec) | |||
[UsedImplicitly] | |||
public record AssetLmdbInfo(string Name, string Version, string[] TableNames); | |||
|
|||
public record TableDumpSpec(string TableName, string CsvFields, bool UniqueKeys, Action<DumpContext, DirectBuffer, DirectBuffer> Dump); | |||
public record TableDumpSpec(string TableName, string CsvFields, bool UniqueKeys, uint[]? VersionCompatibliity, Action<DumpContext, DirectBuffer, DirectBuffer> Dump); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spleliing
@@ -41,4 +41,10 @@ | |||
<ProjectReference Include="$(OkSrcRoot)Unity\Unity.csproj" /> | |||
</ItemGroup> | |||
|
|||
<ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check your formatting
No description provided.