From fc770ec366c48ae3f7e3eccbb57135e6fe82a8b0 Mon Sep 17 00:00:00 2001 From: FrozenSolid Date: Mon, 17 Jul 2023 11:49:54 -0600 Subject: [PATCH] feat: remove terraform resource for ELB bucket ACL configuration (terraform-only change) Stops managing aws_s3_bucket_acl given AWS's new standard for ACLs: https://aws.amazon.com/about-aws/whats-new/2022/12/amazon-s3-automatically-enable-block-public-access-disable-access-control-lists-buckets-april-2023/ When updating, the`module.datadog.aws_s3_bucket_acl.elb_logs[0]` will be destroyed, but this will not impact the actual ACL of the bucket. Thanks, @frozenSolid! --- logs_monitoring_elb.tf | 6 ------ 1 file changed, 6 deletions(-) diff --git a/logs_monitoring_elb.tf b/logs_monitoring_elb.tf index 978fa33..4b3a667 100644 --- a/logs_monitoring_elb.tf +++ b/logs_monitoring_elb.tf @@ -52,12 +52,6 @@ resource "aws_s3_bucket_policy" "elb_logs" { policy = data.aws_iam_policy_document.elb_logs.json } -resource "aws_s3_bucket_acl" "elb_logs" { - count = var.create_elb_logs_bucket ? 1 : 0 - bucket = aws_s3_bucket.elb_logs[0].id - acl = "private" -} - resource "aws_s3_bucket_lifecycle_configuration" "elb_logs" { count = var.create_elb_logs_bucket ? 1 : 0 bucket = aws_s3_bucket.elb_logs[0].id