Skip to content

Update accounts.mdx #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Update accounts.mdx #135

merged 1 commit into from
Jan 15, 2024

Conversation

leonarddt05
Copy link
Contributor

I propose 3 changes for clarity of the text:

Firstly, "The balance of ETH token in the account balance (unit in wei)." - There's a repetition of "balance" in this sentence. I revised it for clarity: "The balance of ETH tokens in the account (unit in wei)."

Secondly, "The number of bytes in the contract bytecode." - I revised it for clarity: "The size of the contract bytecode in bytes."

And lastly, "In the high level..." - I revised it for clarity: "At a high level..."

IMPORTANT: Please do not create a Pull Request without creating an issue first.Any change needs to be discussed before proceeding.

Closing issues

closes #ISSUE_NUMBER_GOES_HERE

...

Description

...

Changes

  • High level
  • changes that
  • you made
  • ...

I propose 3 changes for clarity of the text:

Firstly, "The balance of ETH token in the account balance (unit in wei)." - There's a repetition of "balance" in this sentence. I revised  it for clarity: "The balance of ETH tokens in the account (unit in wei)."

Secondly, "The number of bytes in the contract bytecode." - I revised it for clarity: "The size of the contract bytecode in bytes."

And lastly, "In the high level..." - I revised it for clarity: "At a high level..."
Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for scroll-documentation ready!

Name Link
🔨 Latest commit 4636ad6
🔍 Latest deploy log https://app.netlify.com/sites/scroll-documentation/deploys/6567f90ac4cb610008132f4f
😎 Deploy Preview https://deploy-preview-135.docs.scroll.xyz/en/technology/chain/accounts
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dghelm dghelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good edits. Thanks for taking the time to make a PR.

@dghelm dghelm merged commit 81bc326 into scroll-tech:develop Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants