-
Notifications
You must be signed in to change notification settings - Fork 191
Merge dev into prod #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merge dev into prod #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I've found a grammatical error and edit it. In the sentence "if you've ever used or developed an application on Ethereum, you'll be right home on Scroll," you might be changed to "right home" to "right at home" for clarity.
In the L2ERC721Gateway API section, the withdrawERC721 function description, the parameter list, mentions "deposit" instead of "withdraw." So I changed it to 'withdraw'.
Hello, My aim is to submit a pull request to enhance the inclusivity of the prover documentation by replacing singular male pronouns with gender-neutral alternatives. The change aligns with the broader goal of creating content that is welcoming and accessible to individuals of all genders. Changes Made: In the modified version, "their" is a gender-neutral pronoun that doesn't specify the gender of the committer. It's a way to be inclusive and avoid assumptions about the gender of the person being referred to. Thank you.
I propose 3 changes for clarity of the text: Firstly, "The balance of ETH token in the account balance (unit in wei)." - There's a repetition of "balance" in this sentence. I revised it for clarity: "The balance of ETH tokens in the account (unit in wei)." Secondly, "The number of bytes in the contract bytecode." - I revised it for clarity: "The size of the contract bytecode in bytes." And lastly, "In the high level..." - I revised it for clarity: "At a high level..."
Update from Scroll
fix: text overflow on seach modal
Remove EVM Target Version section
Added EAS mainnet contracts
Add in documentation scroll sepolia faucet scroll.faucetme.pro
I changed a grammatical error which is: In the sentence "These succinct proof can then be posted and verified on Ethereum Layer 1," I changed "proof" to "proofs" for grammatical accuracy.
* fix typos scroll-messenger-cross-chain-interaction.mdx * fix typos enforced-transactions.mdx * fix typo erc1155-token-bridge.mdx * fix typo ethereum-and-scroll-differences.mdx * fix typo makeComponentNode.ts * fix typos link-to-wallet.ts * fix typo button.css
Update polynomial-commitment-schemes.md
Fix broken audit links
Update erc721-nft-bridge.mdx
Update accounts.mdx
Update overview.md
fix: Clarity and copy changes on enforced txs and gas limit and zktrie
* landing page and subscribe footer translated to spanish * footer translation to spanish part 2
Spanish translation catchup
Update language picker
fix merge issue with brand kit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.