Skip to content

Merge dev into prod #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 64 commits into from
Jan 17, 2024
Merged

Merge dev into prod #146

merged 64 commits into from
Jan 17, 2024

Conversation

zzq0826
Copy link
Member

@zzq0826 zzq0826 commented Dec 13, 2023

No description provided.

Turupawn and others added 30 commits October 17, 2023 19:32
Hi,

I've found a grammatical error and edit it. In the sentence "if you've ever used or developed an application on Ethereum, you'll be right home on Scroll," you might be changed to "right home" to "right at home" for clarity.
In the L2ERC721Gateway API section, the withdrawERC721 function description, the parameter list, mentions "deposit" instead of "withdraw." So I changed it to 'withdraw'.
Hello,

My aim is to submit a pull request to enhance the inclusivity of the prover documentation by replacing singular male pronouns with gender-neutral alternatives. The change aligns with the broader goal of creating content that is welcoming and accessible to individuals of all genders. 

Changes Made:

In the modified version, "their" is a gender-neutral pronoun that doesn't specify the gender of the committer. It's a way to be inclusive and avoid assumptions about the gender of the person being referred to. 

Thank you.
I propose 3 changes for clarity of the text:

Firstly, "The balance of ETH token in the account balance (unit in wei)." - There's a repetition of "balance" in this sentence. I revised  it for clarity: "The balance of ETH tokens in the account (unit in wei)."

Secondly, "The number of bytes in the contract bytecode." - I revised it for clarity: "The size of the contract bytecode in bytes."

And lastly, "In the high level..." - I revised it for clarity: "At a high level..."
Remove EVM Target Version section
Add in documentation scroll sepolia faucet scroll.faucetme.pro
I changed a grammatical error which is:

In the sentence "These succinct proof can then be posted and verified on Ethereum Layer 1," I changed "proof" to "proofs" for grammatical accuracy.
* fix typos scroll-messenger-cross-chain-interaction.mdx

* fix typos enforced-transactions.mdx

* fix typo erc1155-token-bridge.mdx

* fix typo ethereum-and-scroll-differences.mdx

* fix typo makeComponentNode.ts

* fix typos link-to-wallet.ts

* fix typo button.css
dghelm and others added 29 commits January 15, 2024 13:26
Update polynomial-commitment-schemes.md
Update erc721-nft-bridge.mdx
fix: Clarity and copy changes on enforced txs and gas limit and zktrie
* landing page and subscribe footer translated to spanish

* footer translation to spanish part 2
@dghelm dghelm merged commit a34b39b into prod Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.