Skip to content

Commit 467d5f8

Browse files
committed
fix issues in e2e
1 parent a18142f commit 467d5f8

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

coordinator/internal/logic/provertask/prover_task.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,9 +206,13 @@ func (b *BaseProverTask) applyUniversal(schema *coordinatorType.GetTaskSchema) (
206206
return nil, nil, fmt.Errorf("no expectedVk found from hardfork %s", schema.HardForkName)
207207
}
208208

209-
decryptionKey, err := hex.DecodeString(b.cfg.Sequencer.DecryptionKey)
210-
if err != nil {
211-
return nil, nil, fmt.Errorf("sequencer decryption key hex-decoding failed")
209+
var decryptionKey []byte
210+
if b.cfg.L2.ValidiumMode {
211+
var err error
212+
decryptionKey, err = hex.DecodeString(b.cfg.Sequencer.DecryptionKey)
213+
if err != nil {
214+
return nil, nil, fmt.Errorf("sequencer decryption key hex-decoding failed")
215+
}
212216
}
213217

214218
ok, uTaskData, metadata, _ := libzkp.GenerateUniversalTask(schema.TaskType, schema.TaskData, schema.HardForkName, expectedVk, decryptionKey)

crates/libzkp/src/tasks.rs

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ pub use chunk_interpreter::ChunkInterpreter;
1010
pub use scroll_zkvm_types::task::ProvingTask;
1111

1212
use crate::{
13-
proofs::{self, BatchProofMetadata, BundleProofMetadata, ChunkProofMetadata},
13+
proofs::{BatchProofMetadata, BundleProofMetadata, ChunkProofMetadata},
1414
utils::panic_catch,
1515
};
1616
use sbv_primitives::B256;
@@ -21,21 +21,17 @@ fn encode_task_to_witness<T: serde::Serialize>(task: &T) -> eyre::Result<Vec<u8>
2121
Ok(bincode::serde::encode_to_vec(task, config)?)
2222
}
2323

24-
fn check_aggregation_proofs<Metadata>(
25-
proofs: &[proofs::WrappedProof<Metadata>],
24+
fn check_aggregation_proofs<Metadata: MultiVersionPublicInputs>(
25+
metadata: &[Metadata],
2626
version: Version,
2727
) -> eyre::Result<()>
28-
where
29-
Metadata: proofs::ProofMetadata,
3028
{
3129
panic_catch(|| {
32-
for w in proofs.windows(2) {
33-
w[1].metadata
34-
.pi_hash_info()
35-
.validate(w[0].metadata.pi_hash_info(), version);
30+
for w in metadata.windows(2) {
31+
w[1].validate(&w[0], version);
3632
}
3733
})
38-
.map_err(|e| eyre::eyre!("Chunk data validation failed: {}", e))?;
34+
.map_err(|e| eyre::eyre!("Metadata validation failed: {}", e))?;
3935

4036
Ok(())
4137
}

crates/libzkp/src/tasks/batch.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ impl BatchProvingTask {
255255
// 2. validate every adjacent proof pair
256256
let witness = self.build_guest_input();
257257
let metadata = BatchInfo::from(&witness);
258-
super::check_aggregation_proofs(self.chunk_proofs.as_slice(), Version::from(self.version))?;
258+
super::check_aggregation_proofs(witness.chunk_infos.as_slice(), Version::from(self.version))?;
259259

260260
Ok(metadata)
261261
}

crates/libzkp/src/tasks/bundle.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ impl BundleProvingTask {
6363
// 2. validate every adjacent proof pair
6464
let witness = self.build_guest_input();
6565
let metadata = BundleInfo::from(&witness);
66-
super::check_aggregation_proofs(self.batch_proofs.as_slice(), Version::from(self.version))?;
66+
super::check_aggregation_proofs(witness.batch_infos.as_slice(), Version::from(self.version))?;
6767

6868
Ok(metadata)
6969
}

0 commit comments

Comments
 (0)