Skip to content

Commit 833a2f5

Browse files
committed
fix according to reviews
1 parent dbd648e commit 833a2f5

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

coordinator/internal/logic/submitproof/proof_receiver.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,6 @@ func (m *ProofReceiverLogic) HandleZkProof(ctx *gin.Context, proofParameter coor
219219
if unmarshalErr := json.Unmarshal([]byte(proofParameter.Proof), &chunkProof); unmarshalErr != nil {
220220
return unmarshalErr
221221
}
222-
log.Info("parse chunkproof", "key", chunkProof.MetaData.ChunkInfo.EncryptionKey)
223222
success, verifyErr = m.verifier.VerifyChunkProof(chunkProof, hardForkName)
224223
if stat := chunkProof.VmProof.Stat; stat != nil {
225224
if g, _ := m.proverSpeed.GetMetricWithLabelValues("chunk", "exec"); g != nil && stat.ExecutionTimeMills > 0 {

coordinator/internal/utils/codec_validium.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,12 @@ type DABatch interface {
1818
}
1919

2020
type daBatchValidiumV1 struct {
21-
Version CodecVersion `json:"version"`
22-
BatchIndex uint64 `json:"batch_index"`
23-
BlobVersionedHash common.Hash `json:"blob_versioned_hash"`
24-
ParentBatchHash common.Hash `json:"parent_batch_hash"`
25-
PostStateRoot common.Hash `json:"post_state_root"`
26-
WithDrawRoot common.Hash `json:"withdraw_root"`
27-
Commitment common.Hash `json:"commitment"`
21+
Version CodecVersion `json:"version"`
22+
BatchIndex uint64 `json:"batch_index"`
23+
ParentBatchHash common.Hash `json:"parent_batch_hash"`
24+
PostStateRoot common.Hash `json:"post_state_root"`
25+
WithDrawRoot common.Hash `json:"withdraw_root"`
26+
Commitment common.Hash `json:"commitment"`
2827
}
2928

3029
type daBatchValidium struct {

crates/libzkp_c/src/lib.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,13 @@ pub unsafe extern "C" fn gen_universal_task(
159159
let pre_task_str = c_char_to_str(task);
160160
let cli = l2geth::get_client();
161161
let decryption_key = if decryption_key_len > 0 {
162-
assert_eq!(decryption_key_len, 32, "len(decryption_key) != 32");
162+
if decryption_key_len != 32 {
163+
tracing::error!(
164+
"gen_universal_task received {}-byte decryption key; expected 32",
165+
decryption_key_len
166+
);
167+
return failed_handling_result();
168+
}
163169
Some(std::slice::from_raw_parts(
164170
decryption_key,
165171
decryption_key_len,

0 commit comments

Comments
 (0)