Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New-GSDriveFile -Fields option never honored (just like #190) #201

Closed
WJurecki opened this issue Jun 5, 2019 · 2 comments
Closed

New-GSDriveFile -Fields option never honored (just like #190) #201

WJurecki opened this issue Jun 5, 2019 · 2 comments
Assignees
@scrthq
Labels
bug

Comments

@WJurecki
Copy link
Contributor

WJurecki commented Jun 5, 2019

New-GSDriveFile -Fields option never honored (just like #190 )

This, I believe, is the same logic bug you fixed in Get-GSDriveFile in bug #190

This is much less of an issue as New-GSDriveFile creates only one file at a time and therefore only returns the results of one file which fits entirely in one round-trip. but it's a bug nonetheless.
@scrthq scrthq self-assigned this Jun 5, 2019
@scrthq
Copy link
Member

scrthq commented Jun 5, 2019

Very valid finding! I'm going to take this and run with checking any functions out that may have the Fields parameter. If it is expected to work, then by all means it should 😃

Thanks @WJurecki !!

@scrthq scrthq added the bug label Jun 5, 2019
scrthq added a commit that referenced this issue Jun 28, 2019
@scrthq
fixed Fields parameter on remaining *-DriveFile functions for #201
469cbd9
@scrthq scrthq mentioned this issue Jun 28, 2019
Merged
scrthq added a commit that referenced this issue Jun 28, 2019
@scrthq
!deploy v2.29.0 with multiple fixes
928e3e1 
## 2.29.0

* [Issue #201](#201)
  * Fixed: Fields parameter on remaining `*-GSDriveFile` functions
* [Issue #197](#197)
  * Updated: All remaining `*-TeamDrive` functions now use the new Drives namespace. All previous functions names have been converted to aliases to maintain backwards compatibility.
  * Added: `Hide-GSDrive`
  * Added: `Show-GSDrive`
* [Issue #184](#184)
  * Added: `EnableCollaborativeInbox` parameter to `Update-GSGroupSettings`
  * Added: `WhoCanDiscoverGroup` parameter to `Update-GSGroupSettings`
scrthq added a commit that referenced this issue Jun 28, 2019
@scrthq
!deploy v2.29.0 with multiple fixes
f68c38f 
## 2.29.0

* [Issue #201](#201)
  * Fixed: Fields parameter on remaining *-GSDriveFile functions
* [Issue #197](#197)
  * Updated: All remaining *-TeamDrive functions now use the new Drives namespace. All previous functions names have been converted to aliases to maintain backwards compatibility.
  * Added: Hide-GSDrive
  * Added: Show-GSDrive
* [Issue #184](#184)
  * Added: EnableCollaborativeInbox parameter to Update-GSGroupSettings
  * Added: WhoCanDiscoverGroup parameter to Update-GSGroupSettings.
@scrthq
Copy link
Member

scrthq commented Jun 28, 2019

Should be all wrapped up now! Thanks for opening this up @WJurecki !

@scrthq scrthq closed this as completed Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scrthq scrthq

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scrthq @WJurecki