Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off calendar notifications #231

Closed
boldperrotta opened this issue Sep 10, 2019 · 2 comments
Closed

Turn off calendar notifications #231

boldperrotta opened this issue Sep 10, 2019 · 2 comments
Assignees
@scrthq
Labels
enhancement

Comments

@boldperrotta
Copy link

Is your feature request related to a problem? Please describe.
When adding a calendar subscription, the function by default enables email notifications for changes to the calendar. $DefaultNotificationType = 'eventChange',

Describe the solution you'd like
I would like to have the function to allow for having $DefaultNotificationType as being able to be set to null or none.

Describe alternatives you've considered
Currently, only way around it is to open the calendar and turn off the notifications.

Additional context
@scrthq scrthq self-assigned this Sep 10, 2019
@scrthq
Copy link
Member

scrthq commented Sep 10, 2019

Makes sense! Thanks, @boldperrotta ! I'm on it

scrthq added a commit that referenced this issue Sep 13, 2019
@scrthq
v2.32.0 release with enhancements for #229 #231 #232 and doc and test…
c034226 
… updates

## 2.32.0 - 2019-09-12

* [Issue #229](#229)
  * Added: `Update-GSGmailLanguageSettings` and `Get-GSGmailLanguageSettings` functions to update/get a users default language settings in Gmail.
* [Issue #231](#231)
  * Added: `Update-GSCalenderSubscription` function to updated existing calendar subscriptions.
  * Removed: Default values for the following parameters on `Add-GSCalendarSubscription` to prevent automatically adding notifications for new CalendarList entries (subscriptions):
    * `DefaultNotificationType`
    * `DefaultNotificationMethod`
    * `DefaultReminderMethod`
    * `DefaultReminderMinutes`
  * Added: `Notifications` and `Reminders` parameters to `Add-GSCalenderSubscription` and `Update-GSCalenderSubscription`
  * Added: `Reminders` parameter to `New-GSCalendarEvent` and `Update-GSCalendarEvent` functions to set custom reminders on calendar events.
  * Added: `Add-GSCalendarEventReminder` and `Add-GSCalendarNotification` helper functions.
  * Updated: `DisableReminder` switch parameter name on `New-GSCalendarEvent` and `Update-GSCalendarEvent` functions to `DisableDefaultReminder` to better align with what that actually effects (default reminder inheritance only, not reminder overrides). The previous parameter name has been set as an alias to maintain backwards compatibility.
  * Added: `RemoveAllReminders` parameter to `Update-GSCalendarEvent` to remove all custom reminders and disable calendar inheritance.
* [Issue #232](#232)
  * Added: `Visibility` parameter on `New-GSCalendarEvent` and `Update-GSCalendarEvent` to set the visibility of a calendar event.
* Miscellaneous
  * Forced `Type` parameter values to lower on the `Add-GSUser*` helper functions to ensure case senstive field matches whats expected.
  * Updated Google .NET SDKs to latest versions.
  * Updated and corrected a LOT of comment based function help.
  * Added function help tests to validate that functions contain expected help content.
@scrthq scrthq mentioned this issue Sep 13, 2019
Merged
scrthq added a commit that referenced this issue Sep 13, 2019
@scrthq
!deploy v2.32.0 (#233)
70e4977 
## 2.32.0 - 2019-09-12

* [Issue #229](#229)
  * Added: `Update-GSGmailLanguageSettings` and `Get-GSGmailLanguageSettings` functions to update/get a users default language settings in Gmail.
* [Issue #231](#231)
  * Added: `Update-GSCalenderSubscription` function to updated existing calendar subscriptions.
  * Removed: Default values for the following parameters on `Add-GSCalendarSubscription` to prevent automatically adding notifications for new CalendarList entries (subscriptions):
    * `DefaultNotificationType`
    * `DefaultNotificationMethod`
    * `DefaultReminderMethod`
    * `DefaultReminderMinutes`
  * Added: `Notifications` and `Reminders` parameters to `Add-GSCalenderSubscription` and `Update-GSCalenderSubscription`
  * Added: `Reminders` parameter to `New-GSCalendarEvent` and `Update-GSCalendarEvent` functions to set custom reminders on calendar events.
  * Added: `Add-GSCalendarEventReminder` and `Add-GSCalendarNotification` helper functions.
  * Updated: `DisableReminder` switch parameter name on `New-GSCalendarEvent` and `Update-GSCalendarEvent` functions to `DisableDefaultReminder` to better align with what that actually effects (default reminder inheritance only, not reminder overrides). The previous parameter name has been set as an alias to maintain backwards compatibility.
  * Added: `RemoveAllReminders` parameter to `Update-GSCalendarEvent` to remove all custom reminders and disable calendar inheritance.
* [Issue #232](#232)
  * Added: `Visibility` parameter on `New-GSCalendarEvent` and `Update-GSCalendarEvent` to set the visibility of a calendar event.
* Miscellaneous
  * Forced `Type` parameter values to lower on the `Add-GSUser*` helper functions to ensure case senstive field matches whats expected.
  * Updated Google .NET SDKs to latest versions.
  * Updated and corrected a LOT of comment based function help.
  * Added function help tests to validate that functions contain expected help content.
@scrthq
Copy link
Member

scrthq commented Sep 13, 2019

Hey @boldperrotta - This is now available in v2.32.0! You'll find a few various helpful bits on Add-GSCalendarSubscription as well as the newly added Update-GSCalendarSubscription! You'll be most interested on the RemoveNotifications switch parameter on Update-GSCalendarSubscription if you want to remove notifications from a calendar already in a user's list, while simply not specifying a notification configuration when creating a new subscription will just not add any notifications by default now. I've also done the same for Reminders as well. Check out the ChangeLog for this release for more info, but here's the relevant bits of everything added around this request:

  • Issue #231
    • Added: Update-GSCalenderSubscription function to updated existing calendar subscriptions.
    • Removed: Default values for the following parameters on Add-GSCalendarSubscription to prevent automatically adding notifications for new CalendarList entries (subscriptions):
      • DefaultNotificationType
      • DefaultNotificationMethod
      • DefaultReminderMethod
      • DefaultReminderMinutes
    • Added: Notifications and Reminders parameters to Add-GSCalenderSubscription and Update-GSCalenderSubscription
    • Added: Reminders parameter to New-GSCalendarEvent and Update-GSCalendarEvent functions to set custom reminders on calendar events.
    • Added: Add-GSCalendarEventReminder and Add-GSCalendarNotification helper functions.
    • Updated: DisableReminder switch parameter name on New-GSCalendarEvent and Update-GSCalendarEvent functions to DisableDefaultReminder to better align with what that actually effects (default reminder inheritance only, not reminder overrides). The previous parameter name has been set as an alias to maintain backwards compatibility.
    • Added: RemoveAllReminders parameter to Update-GSCalendarEvent to remove all custom reminders and disable calendar inheritance.

@scrthq scrthq closed this as completed Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scrthq scrthq

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scrthq @boldperrotta