Feat/16 authentication #33

CamiloGarciaLaRotta · 2019-02-16T21:44:53Z

Description

Advances Implement error handling for all forms #10 by implementing error handling of the login form
Login is now a reducer component.
It performs the authentication and via a callback returns the JWT to the App component.
Services has a side-effect method "authenticate" which POSTs the credentials to the Auth backend.
If the login is succesful, it returns the JWT to Login.
If the login fails, it changes the state of Login to DisplayError
Services has a new type "authResponse" to decode the HTTP response
valueFromEvent was refactored to Services because its used in multiple components
Changed the Sign in with Google dummy button for Sign Up,
which redirects the user to the web-app sign up page
(when it will be available online)

Closes #16

Checklist

Code compiles correctly
All tests passing
There is an open issue linked to this PR
Created tests which fail without the change (if possible)
Extended the README / documentation (if necessary)

coveralls · 2019-02-16T21:49:13Z

Coverage decreased (-7.6%) to 30.45% when pulling d1b4992 on feat/16-auth into 2a9d46d on master.

CamiloGarciaLaRotta · 2019-02-17T21:02:35Z

Travis failed because Coveralls hasn't created a record for the branch.
Probably because we have the free version we get super shitty service.
It took the last branch 1h to create the record.

alexboii

looks okay, as long as it works

the only thing that's really needed here is that you ought to store the jwt in local storage and load it before the HOC mounts, check what the guy does here: https://github.com/jchavarri/chrome-extension-starter-reason-react/blob/master/src/colorSelector.re

there are bindings for it too

alexboii · 2019-02-18T01:35:16Z

manifest.json

@@ -10,8 +10,7 @@
    "default_popup": "popup.html"
  },
  "permissions": [
-    "activeTab",
-    "storage"


why was storage removed? are you not storing the jwt in localstorage?

thats beyond the scope of hooking the extension to the auth API (#16)
The storage of the JWT is in the scope of #19
I can make a PR after for with that enhancement

yeah but wouldn't I have to login every time I click on the chrome extension? the two tasks are hand-in-hand

yes, you currently will have to login every time you click on the extension.
this PR only addresses login in and out for the Login components perspective.
#19 handles login in and out from a broader perspective.

this PR ensures that first step is functional in order to work on the next PRs (#17 #19)

I vote against holding up the PR until #19 is done.
storing the JWT in storage has nothing to do with the Login component and its call to the Auth API

alexboii · 2019-02-18T01:36:52Z

src/ScrapingInput.re

@@ -1,13 +1,5 @@
 open Chrome.Extensions;

-/** Convert value from event to string


why was this moved from here to services? if anything, it needs to be under a new "utilities.re" file

I can move it there, in the PR description I said it was extracted because its used across multiple components

addressed in latest commit

alexboii · 2019-02-18T01:38:53Z

src/App.re

-  | JobApp;
-
-type state = {route};
+type state = {token: string};


Option(string) should be used here, but at this point I don't care

addressed in latest commit

CamiloGarciaLaRotta · 2019-02-18T02:54:45Z

for reference, many people are experiencing the same Coveralls failure: Coveralls GitHub Issue

alexboii

I still think that the jwt storage & login should be the same PR

for then testing the next part (adding job applications) would become a nightmare

if you want I can approve this but I say we wait for #19 before merging

alexboii · 2019-02-19T01:44:39Z

manifest.json

@@ -10,8 +10,7 @@
    "default_popup": "popup.html"
  },
  "permissions": [
-    "activeTab",
-    "storage"


yeah but wouldn't I have to login every time I click on the chrome extension? the two tasks are hand-in-hand

- Advances #10 by implementing error handling of the login form - Login is now a reducer component. It performs the authentication and via a callback returns the JWT to the App component. - Services has a side-effect method "authenticate" which POSTs the credentials to the Auth backend. If the login is succesful, it returns the JWT to Login If the login fails, it changes the state of Login to DisplayError - Services has a new type "authResponse" to decode the HTTP response - valueFromEvent was refactored to Services because its used in multiple components Closes #16

CamiloGarciaLaRotta added the enhancement New feature or request label Feb 16, 2019

CamiloGarciaLaRotta added this to the Deliverable 1 milestone Feb 16, 2019

CamiloGarciaLaRotta self-assigned this Feb 16, 2019

CamiloGarciaLaRotta requested a review from alexboii February 16, 2019 21:44

alexboii suggested changes Feb 18, 2019

View reviewed changes

CamiloGarciaLaRotta force-pushed the feat/16-auth branch from d903c05 to 6638062 Compare February 18, 2019 02:44

alexboii suggested changes Feb 19, 2019

View reviewed changes

CamiloGarciaLaRotta force-pushed the feat/16-auth branch from 6638062 to 300f76b Compare February 19, 2019 16:07

CamiloGarciaLaRotta mentioned this pull request Feb 19, 2019

Feat/19 store token #34

Merged

5 tasks

CamiloGarciaLaRotta added 6 commits February 20, 2019 13:30

feat: style Login error message

fdf466a

refactor: remove unused storage permission

2c844b7

feat: rename Sign-up to Register

2e29b48

reafactor: extract valueFromEvent to Utilities.re

811ea93

feat: App state token is now option(token)

d1b4992

CamiloGarciaLaRotta force-pushed the feat/16-auth branch from 300f76b to d1b4992 Compare February 20, 2019 18:30

alexboii approved these changes Feb 22, 2019

View reviewed changes

CamiloGarciaLaRotta merged commit c0c5781 into master Feb 22, 2019

CamiloGarciaLaRotta deleted the feat/16-auth branch February 22, 2019 18:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/16 authentication #33

Feat/16 authentication #33

CamiloGarciaLaRotta commented Feb 16, 2019

coveralls commented Feb 16, 2019 •

edited

Loading

CamiloGarciaLaRotta commented Feb 17, 2019

alexboii left a comment

alexboii Feb 18, 2019

CamiloGarciaLaRotta Feb 18, 2019

alexboii Feb 19, 2019

CamiloGarciaLaRotta Feb 19, 2019

CamiloGarciaLaRotta Feb 19, 2019

alexboii Feb 18, 2019

CamiloGarciaLaRotta Feb 18, 2019

CamiloGarciaLaRotta Feb 18, 2019

alexboii Feb 18, 2019

CamiloGarciaLaRotta Feb 18, 2019

CamiloGarciaLaRotta commented Feb 18, 2019

alexboii left a comment •

edited

Loading

alexboii Feb 19, 2019

		@@ -1,13 +1,5 @@
		open Chrome.Extensions;

		/** Convert value from event to string

Feat/16 authentication #33

Feat/16 authentication #33

Conversation

CamiloGarciaLaRotta commented Feb 16, 2019

Description

Checklist

coveralls commented Feb 16, 2019 • edited Loading

CamiloGarciaLaRotta commented Feb 17, 2019

alexboii left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CamiloGarciaLaRotta commented Feb 18, 2019

alexboii left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Feb 16, 2019 •

edited

Loading

alexboii left a comment •

edited

Loading