Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Breaking change in nightly toolchain 05.02.2024 #712

Closed
haerdib opened this issue Feb 7, 2024 · 4 comments · Fixed by #715
Closed

Tracking: Breaking change in nightly toolchain 05.02.2024 #712

haerdib opened this issue Feb 7, 2024 · 4 comments · Fixed by #715
Assignees
Labels
F9-dependencies Pull requests that update a dependency file

Comments

@haerdib
Copy link
Contributor

haerdib commented Feb 7, 2024

There's been a breaking change on rust toolchain nightly version 05.02.2024.

Important: do not update curve25519-dalek v4.1.1 to v4.1.2 before updating the rust toolchain to 05.02.24 or above, as it is not backwards compatible.

The following libraries must be updated to be able to go above toolchain 05.02.2024:

Currently blocked due to:

@haerdib haerdib added Z2-blocked F9-dependencies Pull requests that update a dependency file labels Feb 7, 2024
@haerdib haerdib changed the title Tracking Issue: Breaking change in nightly toolchain 05.02.2024 Tracking: Breaking change in nightly toolchain 05.02.2024 Feb 7, 2024
@njelich
Copy link

njelich commented Feb 11, 2024

Ahash patch has passed, that should fix other libraries.

tkaitchuck/aHash#201 (comment)

@haerdib
Copy link
Contributor Author

haerdib commented Feb 12, 2024

Awesome, thank you very much for the heads up!

@njelich
Copy link

njelich commented Feb 14, 2024

curve25519-dalek patch has also passed.

dalek-cryptography/curve25519-dalek#619

Please retest.

@haerdib
Copy link
Contributor Author

haerdib commented Feb 14, 2024

Works like a charm, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F9-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants