MinGW Compile fix #329
Merged
MinGW Compile fix #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an ICMP message is received on Windows 10 for a UDP socket, WSAECONNRESET is reported as an error. In this case, just read again. Thanks to nxrighthere for reporting the issue and helping to nail it down. This fixes sctplab#309.
Two Links missed leading `http(s)://` and were broken. All links to `tools.ietf.org` now consistently use https.
SCTP_CONNECT_X and SCTP_CONNECT_X_DELAYED.
# Conflicts: # usrsctplib/netinet/sctp_usrreq.c # usrsctplib/netinet/sctputil.c
# Conflicts: # programs/ekr_loop.c
- Set minimum Windows Version to Windows 7
Closed
tuexen
reviewed
Jul 30, 2019
usrsctplib/netinet/sctp_pcb.c
Outdated
| @@ -6852,7 +6852,9 @@ sctp_pcb_init() | |||
| #endif | |||
| #if defined(__Userspace__) | |||
| mbuf_initialize(NULL); | |||
| #if !defined(__MINGW32__) | |||
There was a problem hiding this comment.
Please don't insert an ifdef here. Let us call atomic_init() in any case for the userland stack.
Please replace in user_atomic.h
#if defined(__Userspace_os_Windows)
#if !defined(__MINGW32__)
static void atomic_init(void) {} /* empty when we are not using atomic_mtx */
#endif
#else
static inline void atomic_init(void) {} /* empty when we are not using atomic_mtx */
#endif
by
#if defined(__Userspace_os_Windows)
static void atomic_init(void) {} /* empty when we are not using atomic_mtx */
#else
static inline void atomic_init(void) {} /* empty when we are not using atomic_mtx */
#endif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Hopefully) solves #276