From 6e874ddf043fc66cb16ff63c93acf34dfcd394d8 Mon Sep 17 00:00:00 2001 From: Dennis Afanasev <32916582+dennisafa@users.noreply.github.com> Date: Sat, 20 Apr 2019 17:57:37 -0400 Subject: [PATCH 1/3] Small fix in load_balancer --- examples/load_balancer/load_balancer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/load_balancer/load_balancer.c b/examples/load_balancer/load_balancer.c index 0d609c3bd..4b8055205 100644 --- a/examples/load_balancer/load_balancer.c +++ b/examples/load_balancer/load_balancer.c @@ -545,7 +545,7 @@ packet_handler(struct rte_mbuf *pkt, struct onvm_pkt_meta *meta, __attribute__(( ehdr->d_addr.addr_bytes[i] = lb->server[flow_info->dest].d_addr_bytes[i]; } - ip->dst_addr = lb->server[flow_info->dest].d_ip; + ip->dst_addr = rte_cpu_to_be_32(lb->server[flow_info->dest].d_ip); meta->destination = lb->server_port; } From c4b87b60ab99a49cc452dbfcc7c7731ffba4e106 Mon Sep 17 00:00:00 2001 From: dennisa Date: Thu, 15 Aug 2019 13:10:17 -0600 Subject: [PATCH 2/3] Warn user if -m is not specified --- examples/start_nf.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/start_nf.sh b/examples/start_nf.sh index 0eb263f7d..d61bb5cc8 100755 --- a/examples/start_nf.sh +++ b/examples/start_nf.sh @@ -65,6 +65,9 @@ if [[ $dash_dash_cnt -ge 2 ]]; then ONVM_ARGS="$(echo " ""$@" | awk -F "--" '{print $2;}')" # Move to NF arguments shift ${non_nf_arg_cnt} + if [[ $DPDK_ARGS == *"-l"* ]] && [[ ! $ONVM_ARGS == *"-m"* ]]; then + echo "Warning: Include -m flag in order to bind core specified in -l" + fi elif [[ $dash_dash_cnt -eq 0 ]]; then # Dealing with required args shared by all NFs service=$1 From a7984ef58013dc35365d6b8f6f17564429e0a5ab Mon Sep 17 00:00:00 2001 From: dennisa Date: Tue, 20 Aug 2019 14:03:17 -0500 Subject: [PATCH 3/3] Style change --- examples/start_nf.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/start_nf.sh b/examples/start_nf.sh index d61bb5cc8..5d8cc7458 100755 --- a/examples/start_nf.sh +++ b/examples/start_nf.sh @@ -65,7 +65,7 @@ if [[ $dash_dash_cnt -ge 2 ]]; then ONVM_ARGS="$(echo " ""$@" | awk -F "--" '{print $2;}')" # Move to NF arguments shift ${non_nf_arg_cnt} - if [[ $DPDK_ARGS == *"-l"* ]] && [[ ! $ONVM_ARGS == *"-m"* ]]; then + if [[ $DPDK_ARGS =~ "-l" && ! $ONVM_ARGS =~ "-m" ]]; then echo "Warning: Include -m flag in order to bind core specified in -l" fi elif [[ $dash_dash_cnt -eq 0 ]]; then