Fix handling of datetime dtypes #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frances-h
requested review from
amontanez24 and
fealho
and removed request for
a team
amontanez24
approved these changes
Jun 27, 2023
Comment on lines
447
to
448
| if 'windows' not in platform.system().lower(): | ||
| pd.testing.assert_series_equal(output, expected) |
There was a problem hiding this comment.
I see we do this elsewhere but do you know why we skip for windows?
There was a problem hiding this comment.
Not sure. I can't test locally since I don't have a windows machine, but I can try removing it and seeing what happens to the job
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #661 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1639 1641 +2
=========================================
+ Hits 1639 1641 +2
☔ View full report in Codecov by Sentry. |
frances-h
force-pushed
the
issue-657-datetime-dtypes
branch
from
bad016d
to
0ce6a46
Compare
fealho
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #657