fix: ci lint for mod registry and image #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update from upstream
|
|
fanux
reviewed
Apr 30, 2021
|
should not ignore errors! @justadogistaken |
fanux
reviewed
Apr 30, 2021
| } | ||
| err = os.Remove(file.Name()) | ||
| if err != nil { | ||
| logger.Warn(err) |
There was a problem hiding this comment.
The recommended way is to return the error, caller decision write log or not
There was a problem hiding this comment.
I suppose os.Remove/Close ... won't return err regularly. So if error occurs, we log it.
fanux
reviewed
Apr 30, 2021
This was referenced Oct 28, 2021
This was referenced Nov 5, 2021
This was referenced May 24, 2022
Open
Closed
Closed
This was referenced Jan 31, 2023
This was referenced Feb 24, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do golangci-lint on registry&image module, and fixed issues occurred