Fix issue with variadic parameters not being passed like they should

[marac19901990]

Issue:

• willReturnCallback() does not pass unknown named variadic arguments to callback #5455 variadic arguments not being passed to closure

Solution:

• fixed the issue and changed the tests to reflect the changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d16518) 89.11% compared to head (09dc9ed) 89.61%.
Report is 55 commits behind head on 10.5.

Additional details and impacted files

@@             Coverage Diff              @@
##               10.5    #5648      +/-   ##
============================================
+ Coverage     89.11%   89.61%   +0.49%     
- Complexity     6382     6420      +38     
============================================
  Files           673      680       +7     
  Lines         20355    20405      +50     
============================================
+ Hits          18139    18285     +146     
+ Misses         2216     2120      -96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sebastianbergmann]

Does this problem also exist in PHPUnit 9.6?

[marac19901990]

Does this problem also exist in PHPUnit 9.6?

I forgot to check, I'll check and update if needed, my guess is that it doesn't work there either

[marac19901990]

Does this problem also exist in PHPUnit 9.6?

It can't be fixed in 9.6, I made a pull request but then realized that array unpacking for string indexed elements is not supported prior to php 8.1. I'll update the 10.5 pull request with a better solution, but nothing to be done for 9.6

[sebastianbergmann]

Cherry-picked into 10.5 and merged to main from there. Thanks!

[marac19901990]

Cherry-picked into 10.5 and merged to main from there. Thanks!

You didn't have to cherry pick, these are the 10.5 changes, there was another pull request for 9.6 :)

[sebastianbergmann]

I know :) I cherry-picked because I wanted to make some additional changes locally before the merge.