Enable latest-Recommended analysis rules #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lahma
commented
Jul 18, 2024
lahma
commented
- move Directory.Build.props to root
- fix some issues
* move Directory.Build.props to root * fix some issues
| <NoWarn>$(NoWarn);CA1715;</NoWarn> | ||
|
|
||
| <!-- Do not declare visible instance fields --> | ||
| <NoWarn>$(NoWarn);CA1051;</NoWarn> |
There was a problem hiding this comment.
If this is for the CompilationHelper then maybe I should just use properties or readonly fields.
There was a problem hiding this comment.
It's also all structs which don't use properties but public fields.
| @@ -40,7 +42,7 @@ public TextLiteral(string text, StringComparison comparisonType) | |||
| } | |||
| else | |||
| { | |||
| ExpectedChars = ignoreCase ? [Text.ToUpper()[0], Text.ToLower()[0]] : [Text[0]]; | |||
| ExpectedChars = ignoreCase ? [Text.ToUpper(CultureInfo.CurrentCulture)[0], Text.ToLower(CultureInfo.CurrentCulture)[0]] : [Text[0]]; | |||
There was a problem hiding this comment.
When you read the code this makes totally sense. At first I thought this was evil but this is exactly what the argument means. Good job.
sebastienros
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.