From 767d2abb12e3f797c3e4800d47467bbe41cabcfd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20M=C3=BCller?= Date: Fri, 15 Jan 2016 20:10:16 +0100 Subject: [PATCH] fix(SebmGoogleMap): show map when zoom is not set This fixes the following (allowed) use of SebmGoogleMap. When the zoom was not set, the map was empty. ``` ``` closes #81 --- src/directives/google-map.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/directives/google-map.ts b/src/directives/google-map.ts index ff2f27b7e..2420fa348 100644 --- a/src/directives/google-map.ts +++ b/src/directives/google-map.ts @@ -96,7 +96,8 @@ export class SebmGoogleMap implements OnChanges, } private _initMapInstance(el: HTMLElement) { - this._mapsWrapper.createMap(el, {center: {lat: this._latitude, lng: this._longitude}}); + this._mapsWrapper.createMap( + el, {center: {lat: this._latitude, lng: this._longitude}, zoom: this._zoom}); this._handleMapCenterChange(); this._handleMapZoomChange(); this._handleMapMouseEvents(); @@ -118,7 +119,7 @@ export class SebmGoogleMap implements OnChanges, * Sets the zoom level of the map. The default value is `8`. */ set zoom(value: number | string) { - this._zoom = this._convertToDecimal(value); + this._zoom = this._convertToDecimal(value, 8); if (typeof this._zoom === 'number') { this._mapsWrapper.setZoom(this._zoom); } @@ -140,13 +141,13 @@ export class SebmGoogleMap implements OnChanges, this._updateCenter(); } - private _convertToDecimal(value: string | number): number { + private _convertToDecimal(value: string | number, defaultValue: number = null): number { if (typeof value === 'string') { return parseFloat(value); } else if (typeof value === 'number') { return value; } - return null; + return defaultValue; } private _updateCenter() {