Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: improve rule add performance through shadow transactions #180

Closed
wants to merge 2 commits into from

Commits on Nov 1, 2019

  1. db: consolidate some of the code which adds rules to a single filter

    Pay back some of the technical debt in db_col_rule_add(), no logic
    changes in this patch, just removing some code duplication.
    
    Signed-off-by: Paul Moore <paul@paul-moore.com>
    pcmoore committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    fb0dfd1 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. db: add shadow transactions

    Creating a transaction can be very time consuming on large filters since we
    create a duplicate filter tree iteratively using the rules supplied by the
    caller.  In an effort to speed this up we introduce the idea of shadow
    transactions where on a successful transaction commit we preserve the old
    transaction checkpoint and bring it up to date with the current filter and
    save it for future use.  The next time we start a new transaction we check
    to see if a shadow transaction exists, if it does we use that instead of
    creating a new transaction checkpoint from scratch.
    
    Signed-off-by: Paul Moore <paul@paul-moore.com>
    pcmoore committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    bc3a6c0 View commit details
    Browse the repository at this point in the history