Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECURESIGN-1275: Enable RecoverPanic on controllers #532

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

osmman
Copy link
Contributor

@osmman osmman commented Jul 30, 2024

Description:

Enabling RecoverPanic functionality on controllers and adds a new PanicHandler which will record event into controller_runtime_reconcile_panics_total metric.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 30, 2024

@osmman: This pull request references SECURESIGN-1275 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.17.0" version, but no target version was set.

In response to this:

Description:

Enabling RecoverPanic functionality on controllers and adds a new PanicHandler which will record event into controller_runtime_reconcile_panics_total metric.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@SequeI SequeI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 31, 2024
Copy link

openshift-ci bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osmman, SequeI

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c7cae29 into main Jul 31, 2024
13 checks passed
@osmman osmman deleted the tturek/SECURESIGN-1275 branch September 17, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants