fix: return error when Wasm uncompression fails #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasvdam
approved these changes
Sep 29, 2023
mariocao
reviewed
Sep 29, 2023
| expErrMsg: "Data Request Wasm with given hash already exists", | ||
| expErrMsg: "data Request Wasm with given hash already exists", | ||
| }, | ||
| // TO-DO: Add after migrating ValidateBasic logic |
There was a problem hiding this comment.
Is the logic not already there?
seda-chain/x/wasm-storage/types/tx.go
Line 22 in 6a1f50d
There was a problem hiding this comment.
Yes! But Cosmos is encouraging us to put that logic directly in msg_server starting with v0.50. See cosmos/cosmos-sdk#15648
JeancarloBarrios
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that was introduced by an incorrect error handling. It also fixes message server unit tests and adds a few more cases.