From 527a89ad074a3d7c0acadaa1f4b754bc059bbff6 Mon Sep 17 00:00:00 2001 From: Aden Margheriti Date: Fri, 26 Jul 2019 10:08:03 +1000 Subject: [PATCH 1/3] fix(Footer): Fix NZ SEEK Business link --- react/Footer/__snapshots__/Footer.test.js.snap | 2 +- react/Footer/data/tools.js | 3 ++- react/private/withTextProps.js | 4 +++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/react/Footer/__snapshots__/Footer.test.js.snap b/react/Footer/__snapshots__/Footer.test.js.snap index 143a3a1d..7bf9bd65 100644 --- a/react/Footer/__snapshots__/Footer.test.js.snap +++ b/react/Footer/__snapshots__/Footer.test.js.snap @@ -3534,7 +3534,7 @@ exports[`Footer: should render with locale of NZ 1`] = ` Business for sale diff --git a/react/Footer/data/tools.js b/react/Footer/data/tools.js index 0f1c890f..b02e635d 100644 --- a/react/Footer/data/tools.js +++ b/react/Footer/data/tools.js @@ -115,7 +115,8 @@ export const seekSites = [ }, { name: 'Business for sale', - href: 'https://www.seekbusiness.co.nz/?tracking=sk:main:nz:nav:bus', + href: + 'https://www.seekbusiness.com.au/?site=nz&tracking=sk%3Amain%3Anz%3Anav%3Abus', analytics: 'toolbar:business+for+sale', specificLocale: 'NZ' }, diff --git a/react/private/withTextProps.js b/react/private/withTextProps.js index 17231eb6..435183c8 100644 --- a/react/private/withTextProps.js +++ b/react/private/withTextProps.js @@ -38,7 +38,9 @@ export const SizePropTypes = { if (props.size && some(sizes, size => has(props, size))) { return new Error( - `Seems that you've accidentially supplied boolean size along with size='${props.size}' to ${componentName}, please remove one of them. Otherwise boolean prop will overwrite the 'size' prop.` + `Seems that you've accidentially supplied boolean size along with size='${ + props.size + }' to ${componentName}, please remove one of them. Otherwise boolean prop will overwrite the 'size' prop.` ); } }, From ef0035c113f9374de6a8b2cebfe5bf3d7ecae89a Mon Sep 17 00:00:00 2001 From: Aden Margheriti Date: Fri, 26 Jul 2019 10:24:27 +1000 Subject: [PATCH 2/3] remove withTextProps.js from PR --- react/private/withTextProps.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/react/private/withTextProps.js b/react/private/withTextProps.js index 435183c8..17231eb6 100644 --- a/react/private/withTextProps.js +++ b/react/private/withTextProps.js @@ -38,9 +38,7 @@ export const SizePropTypes = { if (props.size && some(sizes, size => has(props, size))) { return new Error( - `Seems that you've accidentially supplied boolean size along with size='${ - props.size - }' to ${componentName}, please remove one of them. Otherwise boolean prop will overwrite the 'size' prop.` + `Seems that you've accidentially supplied boolean size along with size='${props.size}' to ${componentName}, please remove one of them. Otherwise boolean prop will overwrite the 'size' prop.` ); } }, From b7ea15b36a188815de768fe2ba4358cdf77768a5 Mon Sep 17 00:00:00 2001 From: Aden Margheriti Date: Mon, 29 Jul 2019 13:40:52 +1000 Subject: [PATCH 3/3] wip --- react/Footer/__snapshots__/Footer.test.js.snap | 8 ++++---- react/Footer/data/tools.js | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/react/Footer/__snapshots__/Footer.test.js.snap b/react/Footer/__snapshots__/Footer.test.js.snap index 7bf9bd65..7d933b01 100644 --- a/react/Footer/__snapshots__/Footer.test.js.snap +++ b/react/Footer/__snapshots__/Footer.test.js.snap @@ -228,7 +228,7 @@ exports[`Footer: should render when authenticated 1`] = ` Business for sale @@ -1062,7 +1062,7 @@ exports[`Footer: should render when authentication is pending 1`] = ` Business for sale @@ -1896,7 +1896,7 @@ exports[`Footer: should render when unauthenticated 1`] = ` Business for sale @@ -2730,7 +2730,7 @@ exports[`Footer: should render with locale of AU 1`] = ` Business for sale diff --git a/react/Footer/data/tools.js b/react/Footer/data/tools.js index b02e635d..fd510399 100644 --- a/react/Footer/data/tools.js +++ b/react/Footer/data/tools.js @@ -109,7 +109,8 @@ export const seekSites = [ }, { name: 'Business for sale', - href: 'https://www.seekbusiness.com.au/?tracking=sk:main:au:nav:bus', + href: + 'https://www.seekbusiness.com.au/?tracking=sk%3Amain%3Aau%3Anav%3Abus', analytics: 'toolbar:business+for+sale', specificLocale: 'AU' },