Upgrade to amazonka-2.0, include cabal file in the repo, support aeson 2.0 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmoverton
approved these changes
Aug 1, 2023
|
Hey @dmoverton |
This was referenced Aug 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #170
Aims to resolve #169
I realize this PR has some changes that you might not like (like removing package.yaml in favor of including *.cabal files in the repo - because stack gives warning that packages without explicit cabal file won't be supported).
Let me know if you're willing to at least include upgrade to amazonka-2.0 and I can simplify the PR.