From 4489603265d0508e8f7f7f000a371bd8aea25f63 Mon Sep 17 00:00:00 2001 From: Brandon Sneed Date: Wed, 3 Feb 2021 13:02:19 -0800 Subject: [PATCH 1/2] fix(android): fix crash when promise resolves in debug mode --- .../com/segment/analytics/reactnative/core/RNAnalyticsModule.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalyticsModule.kt b/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalyticsModule.kt index b1a69e541..867a15be3 100644 --- a/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalyticsModule.kt +++ b/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalyticsModule.kt @@ -112,7 +112,7 @@ class RNAnalyticsModule(context: ReactApplicationContext): ReactContextBaseJavaM } else { if (BuildConfig.DEBUG) { - return promise.resolve(this) + return promise.resolve(null) } else { return promise.reject("E_SEGMENT_RECONFIGURED", "Segment Analytics Client was allocated multiple times, please check your environment.") From 68911059b3d77489ae7200661b98d53cd7596316 Mon Sep 17 00:00:00 2001 From: Brandon Sneed Date: Thu, 4 Feb 2021 11:20:25 -0800 Subject: [PATCH 2/2] fix(ci): update config.yml --- .circleci/config.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 6c9d1d8a6..5af9d71bb 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -127,7 +127,10 @@ jobs: - restore_cache: key: cocoapods-specs - - run: yarn test-app test:ios:cocoapods + - run: + name: Run Cocoapods Tests + no_output_timeout: 30m + command: yarn test-app test:ios:cocoapods - save_cache: key: cocoapods-specs paths: