Add ready signalling for Visual Tagger integration #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickotoole
pushed a commit
to rockerbox/analytics.js-integrations
that referenced
this pull request
Feb 27, 2020
* Add ready signalling for Visual Tagger integration * update version number
marinhero
pushed a commit
to Wootric/analytics.js-integrations-1
that referenced
this pull request
Apr 24, 2020
* Add ready signalling for Visual Tagger integration * update version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
analytics.jsexpects all integrations to signal when all asynchronous setup actions have completed and they areready. Visual Tagger currently does not do this so any customers relying on thereadycallback that AJS fires currently will experience problems when they flip on Visual Tagger andreadynever happens.For context,
mme-e2erelies onreadyto know when to fire its test events from AJS.https://segment.com/docs/connections/sources/catalog/libraries/website/javascript/#ready