Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast result should also pass log #201

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Broadcast result should also pass log #201

merged 4 commits into from
Feb 7, 2024

Conversation

yzang2019
Copy link
Contributor

Describe your changes and provide context

Problem:
Current Tendermint is not passing log into the broadcast result, this would cause some information missing when trying to debug broadcast failures.

Testing performed to validate your change

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (da59b8d) 57.94% compared to head (017aba2) 57.92%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   57.94%   57.92%   -0.02%     
==========================================
  Files         249      249              
  Lines       33915    33916       +1     
==========================================
- Hits        19651    19645       -6     
- Misses      12692    12705      +13     
+ Partials     1572     1566       -6     
Files Coverage Δ
internal/rpc/core/mempool.go 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

@yzang2019 yzang2019 merged commit 5fb49d9 into main Feb 7, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants