[config] set override unsafeTimeoutOverride to false by default #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonWeng
changed the title
BrandonWeng
commented
Feb 3, 2023
| @@ -1009,7 +1009,7 @@ func (cs *State) receiveRoutine(ctx context.Context, maxSteps int) { | |||
| func (cs *State) fsyncAndCompleteProposal(ctx context.Context, fsyncUponCompletion bool, height int64, span otrace.Span) { | |||
| if fsyncUponCompletion { | |||
| if err := cs.wal.FlushAndSync(); err != nil { // fsync | |||
| panic("error flushing wal after receiving all block parts") | |||
| panic(fmt.Sprintf("error flushing wal after receiving all block parts error=%s", err)) | |||
There was a problem hiding this comment.
debug the flakey test
philipsu522
approved these changes
Feb 3, 2023
Timwood0x10
pushed a commit
to Timwood0x10/sei-tendermint
that referenced
this pull request
Jun 7, 2023
## Describe your changes and provide context This adds the gov proposal type for wasm dependency mapping updates. ## Testing performed to validate your change Based the changes off of this PR: https://github.com/sei-protocol/sei-cosmos/pull/33/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
e.g sei-protocol/sei-cosmos#153
Based on the logs, the data race is between QueryContext and the Finalizeblock for app.checkState.ctx.
I narrowed it cause and it seems like with UnsafeBypassCommitTimeoutOverride=true on by default, the single node consensus is much faster as it doesn't need to wait for timeout, all the datarace failures are happening in the query cli unit tests so i suspect that the queries and the async network are handled in different gorountines and thus have async access to checkState.Ctx (one is updating through finalizeBlock while the unit test is querying it)
Its fine to set to false, since it's mainly exposing the behavior that CLI queries do not have a freshness guarantee, which is expected as the data is constantly changing
Testing performed to validate your change
Tag has this change to set to false, will tag from main after this merges
sei-protocol/sei-cosmos#152