-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question regarding the drop of nanosecond precision timestamp #1189
Comments
Hi @Teles1 ! I found the commit where it was changed: 2583f64#diff-654f2a86f6954fcb6e711df2d4550f16028c3f79c08b2a7bc851dfa227dc37d2 As you can see, it was added when the packet timestamp became more accurate and changed from However, I think it can be a nice change to deprecate In order to stay backward compatible I'd keep the Would you consider implementing this change? |
Sure. Will do. Edit: I mean, I'll definitively give it a shot 👍 I don't know exactly the ins and outs of the tcp protocol but looking at the implementation it doesn't look that will matter all that much. |
The nanosecond precision is lost while re-assembling a TCP stream. I needed to know the timestamp for when a portion of a given stream arrived and unfortunately the precision was lost. Was this a design decision or if a pull request comes in to change this to timespec for example would it get merged in? Thanks
PcapPlusPlus/Packet++/src/TcpReassembly.cpp
Line 29 in 666e292
The text was updated successfully, but these errors were encountered: