Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registry creation method #3

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

kolsean
Copy link
Collaborator

@kolsean kolsean commented May 10, 2023

Update Create method in registry package.

Add new fixture and fix related test.

Update .gitignore file.

For #1

Update `Create` method in `registry` package.

Add new fixture and fix related test.

Update .gitignore file.
@kolsean kolsean requested review from pavelpereyma and TawR1024 May 10, 2023 13:46
@kolsean kolsean self-assigned this May 10, 2023
Copy link
Contributor

@pavelpereyma pavelpereyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@TawR1024 TawR1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kolsean kolsean merged commit 2517c3e into selectel:main May 11, 2023
@kolsean kolsean deleted the fix-registry-create branch May 11, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants