Merge pull request #2388 from seleniumbase/expand-firefox-pref-allowa…

…ble-values Expand firefox_pref to allow URLs as VALUEs in KEY:VALUE pairs
seleniumbase · Dec 23, 2023 · 2036a7b · 2036a7b
2 parents 9f8ce98 + da65901
commit 2036a7b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/requirements.txt b/requirements.txt
@@ -1,7 +1,7 @@
 pip>=23.3.2
 packaging>=23.2
 setuptools>=68.0.0;python_version<"3.8"
-setuptools>=69.0.2;python_version>="3.8"
+setuptools>=69.0.3;python_version>="3.8"
 wheel>=0.42.0
 attrs>=23.1.0
 certifi>=2023.11.17

diff --git a/seleniumbase/__version__.py b/seleniumbase/__version__.py
@@ -1,2 +1,2 @@
 # seleniumbase package
-__version__ = "4.22.2"
+__version__ = "4.22.3"
diff --git a/seleniumbase/core/browser_launcher.py b/seleniumbase/core/browser_launcher.py
@@ -1270,7 +1270,10 @@ def _set_firefox_options(
                 f_pref = firefox_pref_item.split(":")[0]
                 f_pref_value = firefox_pref_item.split(":")[1]
                 needs_conversion = True
-            else:  # More than one ":" in the set. (Too many!)
+            elif firefox_pref_item.count("://") == 1:
+                f_pref = firefox_pref_item.split(":")[0]
+                f_pref_value = ":".join(firefox_pref_item.split(":")[1:])
+            else:  # More than one ":" in the set without a URL.
                 raise Exception(
                     'Incorrect formatting for Firefox "pref:value" set!'
                 )

diff --git a/setup.py b/setup.py
@@ -134,7 +134,7 @@
         'pip>=23.3.2',
         'packaging>=23.2',
         'setuptools>=68.0.0;python_version<"3.8"',
-        'setuptools>=69.0.2;python_version>="3.8"',
+        'setuptools>=69.0.3;python_version>="3.8"',
         'wheel>=0.42.0',
         'attrs>=23.1.0',
         "certifi>=2023.11.17",