Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#189 - add paperless-ng template #190

Merged
merged 2 commits into from
Dec 12, 2020
Merged

#189 - add paperless-ng template #190

merged 2 commits into from
Dec 12, 2020

Conversation

Tooa
Copy link
Contributor

@Tooa Tooa commented Dec 10, 2020 •
edited
Loading

Closes #189

@Tooa Tooa changed the title WIP 189 - add paperless-ng template WIP #189 - add paperless-ng template Dec 10, 2020
@jrdnlc
Copy link
Contributor

jrdnlc commented Dec 10, 2020

Please change branch to testing.

@Tooa Tooa changed the base branch from master to testing December 10, 2020 16:22
@Tooa Tooa changed the title WIP #189 - add paperless-ng template WIP: #189 - add paperless-ng template Dec 10, 2020
@Tooa
Copy link
Contributor Author

Tooa commented Dec 10, 2020 •
edited
Loading

@jrdnlc swiched to testing

@jonaswinkler
Copy link

Awesome stuff. How exactly does this work? Will it pull images from docker hub or build the image from the GitHub repository? Never used unRAID.

Ping me if anything is required for this.

@Roxedus
Copy link
Member

Roxedus commented Dec 10, 2020

@jonaswinkler It will grab it from dockerhub, the template is used to form a docker run command

@jonaswinkler jonaswinkler mentioned this pull request Dec 10, 2020
Closed
@Tooa Tooa changed the title WIP: #189 - add paperless-ng template #189 - add paperless-ng template Dec 10, 2020
@Tooa
Copy link
Contributor Author

Tooa commented Dec 10, 2020

I think I'm finished. Can someone take a look at this?

@jrdnlc
Copy link
Contributor

jrdnlc commented Dec 10, 2020

I can merge it and test.

Roxedus
Roxedus requested changes Dec 11, 2020
View reviewed changes
Copy link
Member

@Roxedus Roxedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Some small things I would do differently

templates/paperless-ng.xml Outdated Show resolved Hide resolved
templates/paperless-ng.xml Outdated Show resolved Hide resolved
@Tooa
Copy link
Contributor Author

Tooa commented Dec 11, 2020

Thanks for your review @Roxedus. I like your suggestions! Will tackle your comments soon later the day.

@Tooa Tooa requested a review from Roxedus December 12, 2020 15:39
@Roxedus Roxedus merged commit a8e6772 into selfhosters:testing Dec 12, 2020
@jonaswinkler
Copy link

Awesome. If anyone asks me again how to setup this on unRaid, I'll simply point them towards here.

@Tooa
Copy link
Contributor Author

Tooa commented Dec 13, 2020

@jonaswinkler Once @Roxedus merges the testing branch into master, the template will be available in Unraids community application store (see here). As maintainer of the paperless Unraid template (see here), I will try to get a few users into testing paperless-ng in order to generate feedback for you.

@Tooa Tooa mentioned this pull request Dec 13, 2020
Closed
@Tooa Tooa deleted the feature/189 branch December 13, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roxedus Roxedus Roxedus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CA Template Request - paperless-ng
4 participants
@Tooa @jrdnlc @jonaswinkler @Roxedus