Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting the feature flag for new dashboard #794

Merged
merged 0 commits into from
May 4, 2023
Merged

Conversation

chance-an
Copy link
Contributor

@chance-an chance-an commented May 3, 2023

Support switching different UI styles

capture1

Currently, the new style is only static, real data will be filled in in later PRs.

Can be previewed from my namespace.

This closes #793

@chance-an chance-an added enhancement New feature or request ui UI related work labels May 3, 2023
@chance-an chance-an requested review from neutralino1, tscurtu and a team May 3, 2023 23:56
@@ -38,7 +38,7 @@
"react-markdown": "^8.0.3",
"react-medium-image-zoom": "^4.4.3",
"react-plotly.js": "^2.5.1",
"react-router-dom": "^6.8.1",
"react-router-dom": "^6.11.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a bug in react-router side.

@@ -104,50 +118,50 @@ function Router() {
const versionResponse: VersionPayload = await (await fetch("/api/v1/meta/versions")).json();
const serverVersion = versionResponse.server.join('.');

posthog.init(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only indentation changes here.

Copy link
Contributor

@tscurtu tscurtu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :shipit:

@chance-an chance-an added this pull request to the merge queue May 4, 2023
Merged via the queue into main with commit 95feec0 May 4, 2023
@chance-an chance-an deleted the c/integrate_new branch May 4, 2023 22:07
jrcribb pushed a commit to jrcribb/sematic that referenced this pull request Apr 9, 2024
Support switching different UI styles


![capture1](https://user-images.githubusercontent.com/1046489/236075454-6d9eeb1f-5070-4644-9f5d-af4717f641a9.gif)

Currently, the new style is only static, real data will be filled in in
later PRs.

Can be previewed from *my* namespace.

This closes [sematic-ai#793](sematic-ai#793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui UI related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New UI] Feature Flag
2 participants