This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
BIG refactoring, add far more tokens in the different ASTs and AST ge… #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neric Description: sgrep sometimes fails with an OCaml exception about an empty list of tokens (either FakeTok error or min_max_ii error) because a metavariable may match something (an expr or stmt) that does not contain any token information. This in turns mean we can not display location information for this matched thing. This diff should help fix semgrep/semgrep#73 and semgrep/semgrep#52 because it adds lots of token information in the different ASTs. I originally skipped those tokens because I wanted an AST, not a CST, but in the ends it bites back and we want many of those tokens (at least enough token so we never get the error above). See ast_generic.ml for the rational. test plan: make test
ievans
approved these changes
Feb 4, 2020
ulziibay
reviewed
Feb 4, 2020
Comment on lines
+404
to
+407
| | Return of tok * expr option | ||
| (* less: switch to label? but PHP accept integers no? *) | ||
| | Continue of tok * expr option | ||
| | Break of tok * expr option |
There was a problem hiding this comment.
I do believe this is the important line! DId you want to add specific test for this or do the existing test cover this ?
ulziibay
approved these changes
Feb 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…neric
Description: sgrep sometimes fails with an OCaml exception about an empty
list of tokens (either FakeTok error or min_max_ii error) because
a metavariable may match something (an expr or stmt) that does not contain
any token information. This in turns mean we can not display location
information for this matched thing.
This diff should help fix
semgrep/semgrep#73
and
semgrep/semgrep#52
because it adds lots of token information in the different ASTs.
I originally skipped those tokens because I wanted an AST, not a CST,
but in the ends it bites back and we want many of those tokens
(at least enough token so we never get the error above).
See ast_generic.ml for the rational.
test plan:
make test