Mocha unit tests - utilities and default options schema check #34
Conversation
Current coverage is 100%
|
|
@chefArchitect Want me to review and merge? Or shall I wait until you finish pushing changes? |
|
I suggest we do this in small iterations. Check this one first and in the following days I'll be pushing more updates. |
|
@chefArchitect Reviewing this now. |
| @@ -14,5 +14,7 @@ setInterval(function() { | |||
| client.act('role:create', { | |||
| max: 100, | |||
| min: 25 | |||
| }, console.log); | |||
| }, function(err, msg) { | |||
There was a problem hiding this comment.
Would you mind not mixing stylistic changes with functional changes on the PR? 🐰
There was a problem hiding this comment.
Sorry @nfantone - my bad. Forgot to rollback this one.
* Fixed lint related issues * Reverted examples/client.js to original
|
@nfantone Just pushed all latest unit tests + linting issue fixes. If you want me to write tests that cover Hooks related functionality, let me know. |
|
Good stuff. I'll take a look, ASAIC. |
|
Hi @nfantone. Are you planning to merge this PR anytime soon or you want me to close it? Didn't have any feedback from you for a while now. |
|
I'm sorry for the long silence. I've been unusually busy lately. I'm all up for this. I'll try to review it before tomorrow.
|
|
Cool! Thanks. |
|
@chefArchitect Ok, so first of all: amazing work. Thank you very much for your efforts and contribution. Everything LGTM. I can't ask you to do anything more than what you already did. Just two lil' comments before merging this.
|
|
@nfantone Ok, we're cool now. Synced wit the 'develop' branch and reverted the gulp config, excluding it also from linting. Sorry for the inconvenience. |
|
There, done. @chefArchitect Thanks again. I'll update the docs to add a contributors list with your name on it. EDIT: I owe you a 🍺 |
|
@nfantone If you come by Athens anytime soon, let me know :) |
I have created an initial set of Mocha tests covering two sections:
More unit tests will follow for the rest of the modules.