Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idl 60 fabric console vault integration rebase #7

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
16f9e74
update release notes (#369)
dshuffma-ibm Feb 16, 2023
5619eed
IDL-60 Allow mannual trigger of Docker workflow
lbandrov Mar 1, 2023
92bcb87
Develop rebase (#5)
lbandrov Jun 18, 2024
b026045
IDL-60 implement example vault endpoint
lbandrov Feb 23, 2023
4df9763
IDL-60 Example integration Apollo, Athena Vault
lbandrov Feb 24, 2023
a9c295a
IDL-60 Implement Vault API in Athena, Vault storage for identities an…
lbandrov Feb 26, 2023
f308f53
IDL-60 Remove not needed console logs and fix error rethrow
lbandrov Feb 26, 2023
1e87a69
IDL-60 removed delete identity endpoint from athena
lbandrov Feb 28, 2023
cdd51d9
IDL-60 Disable remove identity button.
lbandrov Mar 1, 2023
a9d30b2
IDL-60 Change build configs
lbandrov Mar 1, 2023
b51db6d
IDL-60 Fix API docs
lbandrov Mar 1, 2023
3a95563
IDL-60 read vault secrets from file
lbandrov Mar 2, 2023
82b9aa2
IDL-60 Set vault to be default identity storage
lbandrov Mar 2, 2023
f29daf8
IDL-60 Fix timing of loading vault secrets
lbandrov Mar 2, 2023
8ed5d40
IDL-60 handle error if vault config file is missing
lbandrov Mar 2, 2023
ddab1b1
IDL-60 Implement base64 encoding and decoding of identities and chang…
lbandrov Mar 3, 2023
6ef22b3
IDL-60 Fix throwing when peers, orderer, cases, etc, are undefined wh…
lbandrov Mar 4, 2023
228741b
IDL-60 Implement populating root certs in identity
lbandrov Mar 10, 2023
db4f3dd
IDL-60 Fix wrong authentication check middleware
lbandrov Mar 14, 2023
92e4b07
IDL-60 return empty identity object when no identities available in v…
lbandrov Mar 14, 2023
c5e0235
IDL-60 fix vault config path
lbandrov Mar 14, 2023
b2d5697
IDL-81 Change the property format of private key and msp id
lbandrov Mar 16, 2023
45b411a
IDL-60 fix lint warnings
lbandrov Mar 26, 2023
d12e405
IDL-60 updated eslint version to 2018
lbandrov Mar 31, 2023
9c4451f
IDL-60 refactored vault communication to resolve security vulnerabili…
lbandrov Apr 10, 2023
8658f8b
IDL-60 axios installed
lbandrov Apr 10, 2023
af9de75
IDL-60 Fix calling wrong method when retried vault connection
lbandrov Apr 20, 2023
3a27df0
IDL-60 Fix calling retry methods with wrong parameters
lbandrov Apr 20, 2023
0f5c849
IDL-60 Add logs to see when the Vault client reinitializes the token
lbandrov Apr 20, 2023
dd34546
IDL-60 Does not override msp_id in identity if it is already set
lbandrov Apr 21, 2023
cde102f
IDL-60 Remove not neede declaration of variable
lbandrov Apr 21, 2023
8b87dc0
IDL-60 Fix login url
lbandrov Apr 27, 2023
570b3fa
IDL-60 Fixes after rebasing and testing
lbandrov Jul 8, 2024
bf3f99c
IDL-60 Add delete secret from vault endpoint and improve vault config…
lbandrov Jul 22, 2024
29cedb9
IDL-60 Use vault integration if Vault client is initialised successfu…
lbandrov Jul 23, 2024
4746c6f
IDL-60 Remove not needed react env variable
lbandrov Jul 23, 2024
6553fe9
Enable workflows for all branches
yzhivkov Jul 23, 2024
7ba4a4c
Add on-demand workflow
yzhivkov Jul 23, 2024
520b24a
IDL-60 Increase ws version to patched version without vulnerabilities
lbandrov Jul 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
IDL-60 Fix calling retry methods with wrong parameters
Signed-off-by: Lyubomir Bandrov <lyubomir.bandrov@senofi.ca>
lbandrov committed Jul 23, 2024
commit 3a27df087edf0ab5b8022bee57b3c4a9f8d34a7b
4 changes: 2 additions & 2 deletions packages/athena/vault/vault_client.js
Original file line number Diff line number Diff line change
@@ -62,7 +62,7 @@ class VaultClient {
.catch(async (error) => {
if (!isRetried && error && error.response && (error.response.status === 401 || error.response.status === 403)) {
await this.init();
return await this.readSecret(true);
return await this.readSecret(secretName, true);
}
this.logger.error('Unable to read secret!', error);
throw error;
@@ -81,7 +81,7 @@ class VaultClient {
.catch(async (error) => {
if (!isRetried && error && error.response && (error.response.status === 401 || error.response.status === 403)) {
await this.init();
return await this.upsertSecret(true);
return await this.upsertSecret(secretName, data, true);
}
this.logger.error('Unable to create secret!', error);
throw error;