Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 4.0.5 master #8

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Merge 4.0.5 master #8

merged 5 commits into from
Feb 5, 2024

Conversation

Kaapp
Copy link

@Kaapp Kaapp commented Feb 5, 2024

Update to 4.0.5 so we can update the platform to 4.0.5 as well. See: https://github.com/sensat/platform/pull/1907

Same process as before:

git remote add upstream git@github.com:visgl/loaders.gl.git
git fetch upstream
git merge --no-ff v4.0.4
# no merge conflicts this time
yarn install
yarn build
git commit # although did this via Github Desktop
git push -u origin merge-4.0.4-master

@Kaapp Kaapp requested review from Gmadges and Rennzie February 5, 2024 17:56
@Kaapp Kaapp self-assigned this Feb 5, 2024
@Kaapp Kaapp force-pushed the merge-4.0.5-master branch from f90f64a to 2e8f636 Compare February 5, 2024 19:06
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7789582094

  • -2 of 11 (81.82%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 67.5%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/tile-converter/src/3d-tiles-converter/3d-tiles-converter.ts 2 3 66.67%
modules/tile-converter/src/converter-cli.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 7125757601: 0.01%
Covered Lines: 69164
Relevant Lines: 103699

💛 - Coveralls

@Kaapp
Copy link
Author

Kaapp commented Feb 5, 2024

i've skipped the node 16 tests for now as puppeteer (the testing library used) updated 8 hours ago to a new major version which doesn't support node 16 and i can't get yarn to play ball and use the old version as it's specified in a dependency of a dependency. i'll keep an eye on how they fix this upstream and update accordingly in future.

@Kaapp Kaapp merged commit 9a16adb into master Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants