Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.12 #528

Merged
merged 14 commits into from
Dec 28, 2023
Merged

Python 3.12 #528

merged 14 commits into from
Dec 28, 2023

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

#523

What does this implement/fix? Explain your changes.

  • Test system modified
  • Python 3.12 added to test.yml

Any other comments?

@sepandhaghighi sepandhaghighi added this to the PYCM 4.1 milestone Dec 28, 2023
@sepandhaghighi sepandhaghighi self-assigned this Dec 28, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (022f77e) 99.33% compared to head (537267b) 99.33%.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev     #528   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files          14       14           
  Lines        3112     3112           
  Branches      467      467           
=======================================
  Hits         3091     3091           
  Misses          8        8           
  Partials       13       13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sepandhaghighi sepandhaghighi marked this pull request as ready for review December 28, 2023 14:09
sadrasabouri
sadrasabouri approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great job

@sadrasabouri sadrasabouri merged commit d492ebe into dev Dec 28, 2023
46 checks passed
@sadrasabouri sadrasabouri deleted the python3.12 branch December 28, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadrasabouri sadrasabouri sadrasabouri approved these changes

@alirezazolanvari alirezazolanvari Awaiting requested review from alirezazolanvari

Assignees

@sepandhaghighi sepandhaghighi

Labels
major test
Projects
None yet
Milestone
PYCM 4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sepandhaghighi @sadrasabouri