Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tunnel: add localproxy command #86

Merged
merged 6 commits into from
May 11, 2020
Merged

tunnel: add localproxy command #86

merged 6 commits into from
May 11, 2020

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented May 6, 2020 •
edited
Loading

After #85 done

TODO

  • add README

@at-wat at-wat self-assigned this May 6, 2020
@at-wat at-wat force-pushed the tunnel/add-localproxy-cmd branch from 5268324 to bc55b4d Compare May 6, 2020 09:31
@at-wat at-wat force-pushed the tunnel/add-source-proxy branch 2 times, most recently from b28a5c6 to 34ed199 Compare May 7, 2020 03:27
@at-wat at-wat force-pushed the tunnel/add-localproxy-cmd branch from bc55b4d to e871915 Compare May 7, 2020 03:38
@at-wat at-wat mentioned this pull request May 7, 2020
Merged
@kt3k kt3k mentioned this pull request May 7, 2020
Closed
@at-wat at-wat force-pushed the tunnel/add-localproxy-cmd branch from e871915 to 3625c25 Compare May 7, 2020 12:43
@at-wat at-wat changed the base branch from tunnel/add-source-proxy to master May 7, 2020 12:44
@at-wat at-wat marked this pull request as ready for review May 7, 2020 12:44
@at-wat at-wat force-pushed the tunnel/add-localproxy-cmd branch 2 times, most recently from ca414b6 to 3436a4d Compare May 8, 2020 01:27
@at-wat
Copy link
Member Author

at-wat commented May 8, 2020

failing on Go 1.12 due to golang/go#30374

@at-wat at-wat force-pushed the tunnel/add-localproxy-cmd branch from 3436a4d to 4067427 Compare May 8, 2020 01:49
@codecov-io
Copy link

codecov-io commented May 8, 2020 •
edited
Loading

Codecov Report

Merging #86 into master will decrease coverage by 1.28%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   31.40%   30.12%   -1.29%     
==========================================
  Files          16       17       +1     
  Lines         866      903      +37     
==========================================
  Hits          272      272              
- Misses        552      589      +37     
  Partials       42       42
Impacted Files Coverage Δ
tunnel/cmd/localproxy/main.go 0.00% <0.00%> (ø)
tunnel/proxy.go 0.00% <0.00%> (ø)
tunnel/tunnel.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9a3839...baffabe. Read the comment docs.

@at-wat at-wat force-pushed the tunnel/add-localproxy-cmd branch 3 times, most recently from e9fac1f to 5252183 Compare May 8, 2020 02:37
@at-wat at-wat requested a review from kamatama41 May 8, 2020 05:06
@at-wat at-wat force-pushed the tunnel/add-localproxy-cmd branch from 5252183 to e6cb2c2 Compare May 9, 2020 08:28
@at-wat at-wat removed the request for review from kamatama41 May 9, 2020 08:47
@at-wat at-wat force-pushed the tunnel/add-localproxy-cmd branch from 312b552 to 89298bc Compare May 11, 2020 06:39
@at-wat at-wat requested a review from kt3k May 11, 2020 06:58
@at-wat
Copy link
Member Author

at-wat commented May 11, 2020

@kt3k please take a look

kt3k
kt3k reviewed May 11, 2020
View reviewed changes
tunnel/cmd/README.md Outdated

1. Build the localproxy
```shell
cd localproxy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe go build . command is missing in the next line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added the build command.

kt3k
kt3k reviewed May 11, 2020
View reviewed changes
tunnel/cmd/README.md
```
4. Connect to the server via proxy
```shell
$ ssh localhost -p 2222
Copy link
Contributor

@kt3k kt3k May 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to login via localproxy on my machine! It looks working 👍

@at-wat at-wat requested a review from kt3k May 11, 2020 08:38
kt3k
kt3k approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@at-wat at-wat merged commit 06e9a38 into master May 11, 2020
@at-wat at-wat deleted the tunnel/add-localproxy-cmd branch May 11, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees

@at-wat at-wat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@at-wat @codecov-io @kt3k