Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distance column in the data frame coming from result of find function #969

Closed
serengil opened this issue Jan 25, 2024 · 1 comment
Closed

distance column in the data frame coming from result of find function #969

serengil opened this issue Jan 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@serengil
Copy link
Owner

Find function returns a pandas dataframe and the distance column named as {model_name}_{distance_metric}. this is not a good practice. we should give name it distance by default.

Module: https://github.com/serengil/deepface/blob/master/deepface/modules/recognition.py
@serengil serengil added the enhancement New feature or request label Jan 25, 2024
@serengil serengil mentioned this issue Jan 26, 2024
Merged
@serengil
Copy link
Owner Author

Closed with PR - #974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serengil