Filesystem #1305
Merged
Filesystem #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets
#1301
What has been done
With this PR, path handling has been updated. In the issue mentioned above, there was a discussion about
pathlibversusos.path. Althoughpathliboffers more advantages,os.pathis widely used in this project, so the path handling code was updated usingos.path.How to test
Remove the
~/.deepfacefolder and run the tests to ensure that all the required models and weights are downloaded and saved correctly.Run the tests again to ensure that models and weights are not downloaded again and are loaded correctly.
make test