Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: adding yolov11 into face detection portfolio #1397

Merged
merged 12 commits into from
Dec 11, 2024

Conversation

nriviera
Copy link

@nriviera nriviera commented Dec 9, 2024

Tickets

feature request: #1392

What has been done

This PR introduces YOLOv11[s,n,m]-face as face detector and face embedding generation

Unexpectedly yolo-facev11 is not generating any keypoint

README.md Show resolved Hide resolved
@serengil
Copy link
Owner

serengil commented Dec 9, 2024

what do you mean as Unexpectedly yolo-facev11 is not generating any keypoint ?

@serengil
Copy link
Owner

serengil commented Dec 9, 2024

as i know, yolo is a face detector model. does it have a face recognition model as well?

@serengil
Copy link
Owner

serengil commented Dec 9, 2024

When you add a facial recognition model, you must add its pre-tuned threshold here: https://github.com/serengil/deepface/blob/master/deepface/modules/verification.py#L409

Again, AFAIK yolo is a face detection model not facial recognition.

@roberto-corno-ntt
Copy link

as i know, yolo is a face detector model. does it have a face recognition model as well?

according to ultralytics documentation (https://docs.ultralytics.com/modes/predict/#inference-arguments) the predict method is accepting the embed parameter that "Specifies the layers from which to extract feature vectors or embeddings. Useful for downstream tasks like clustering or similarity search."

@roberto-corno-ntt
Copy link

what do you mean as Unexpectedly yolo-facev11 is not generating any keypoint ?

yolo-facev8 is detecting eyes through keypoints, while for v11 keypoints are always None

@serengil
Copy link
Owner

serengil commented Dec 9, 2024

what do you mean as Unexpectedly yolo-facev11 is not generating any keypoint ?

yolo-facev8 is detecting eyes through keypoints, while for v11 keypoints are always None

then, would you please add this information as a comment in yolo.py

…ading in terms of documentaion. In the end not suitable for recognition at all. Removed YoloFacialRecognition
tests/visual-test.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@serengil
Copy link
Owner

Failed at linting step

************* Module deepface.DeepFace
deepface/DeepFace.py:99:0: C0301: Line too long (117/100) (line-too-long)
deepface/DeepFace.py:391:0: C0301: Line too long (101/100) (line-too-long)
************* Module deepface.modules.modeling
deepface/modules/modeling.py:41:0: C0301: Line too long (113/100) (line-too-long)
************* Module deepface.modules.representation
deepface/modules/representation.py:39:0: C0301: Line too long (1[18](https://github.com/serengil/deepface/actions/runs/12260412979/job/34205503644?pr=1397#step:5:19)/100) (line-too-long)
************* Module deepface.models.face_detection.Yolo
deepface/models/face_detection/Yolo.py:98:0: C0301: Line too long (102/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.99/10

Ref: https://github.com/serengil/deepface/actions/runs/12260412979/job/34205503644?pr=1397

@serengil
Copy link
Owner

@nriviera will merge this to main when you resolve linting issues

@serengil serengil merged commit a402f09 into serengil:master Dec 11, 2024
2 checks passed
@serengil
Copy link
Owner

Thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants