Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for onboarding #2873

Closed
wants to merge 7 commits into from
Closed

Add support for onboarding #2873

wants to merge 7 commits into from

Conversation

jamesbt365
Copy link
Member

@jamesbt365 jamesbt365 commented May 22, 2024 •
edited
Loading

Fixes #2860

First time implementing builders and this one is nasty.

TODO:

  • Add support for getting the current guilds onboarding
  • Create builders
  • Make said builders work and execute (add the method in Http too)
  • Add methods on Guild, GuildId, PartialGuild etc etc
  • Document stuff (except new() methods)
  • Write docs for new() methods on the builders once everything is stable.
  • Fix re-export shenanigans
  • Carefully look over visibility of objects.
  • impl From<Onboarding> for EditOnboarding etc
  • Model sizes update
  • Testing

@github-actions github-actions bot added model Related to the `model` module. builder Related to the `builder` module. http Related to the `http` module. labels May 22, 2024
@jamesbt365 jamesbt365 changed the title Partial support for onboarding Add support for onboarding May 22, 2024
@jamesbt365 jamesbt365 force-pushed the onboarding branch 2 times, most recently from 5465466 to eed934c Compare May 25, 2024 17:16
@jamesbt365 jamesbt365 added enhancement An improvement to Serenity. discord feature Related to Discord's functionality. labels Jun 1, 2024
@jamesbt365
Copy link
Member Author

Its clear this won't be merged or worked on until discord figures out what they actually want with onboarding. There are numerous issues with the docs and thus should stay unsupported until then.

Main stoppers are these.
discord/discord-api-docs#6320
discord/discord-api-docs#6887

@jamesbt365 jamesbt365 closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builder Related to the `builder` module. discord feature Related to Discord's functionality. enhancement An improvement to Serenity. http Related to the `http` module. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing API endpoints for guild onboarding
1 participant
@jamesbt365