Thread channels don't appear to be cached

[devoxin]

When running a starboard bot with pretty much a default configuration, the bot is unable to find thread channels in its cache causing events to be discarded.

The bot is present in the thread's member list and can receive events for the channel.
Can provide more information on request but at present, not sure what else to mention.

[GnomedDev]

Reproduced locally. Looking into it more.

[GnomedDev]

Okay, looking at discord's developer documentation and serenity's implementation, it looks like we are modeling threads as GuildChannels as expected, but then storing the tread in Guild::threads as discord does.. leading to guild.channels lookups to fail.

This doesn't sound intuitive or good at all, as you can't guarantee a message being sent to a channel has it's Message::channel_id in Guild::channels, but on the other hand we are somewhat following discord's modeling which is generally a good thing.

There are two solutions to this:

• Stop modeling threads as GuildChannels, go full out Discord

This will remove a bunch of fields from GuildChannel, so memory wins, but keep the status quo that runs into this issue.

• Start modeling threads as full channels

This would involve moving threads to Guild::channels and possibly removing the Guild::threads field. This would require custom deserialization for Guild, which is not impossible but would be annoying.

I'll open a poll on the serenity discord and we can see where to go from here.