Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix before for archived public and private threads having incorrect before #3015

Closed
wants to merge 2 commits into from
Closed

Fix before for archived public and private threads having incorrect before #3015

wants to merge 2 commits into from

Conversation

BigBadE
Copy link

@BigBadE BigBadE commented Nov 4, 2024

Fixes #3014

@github-actions github-actions bot added model Related to the `model` module. http Related to the `http` module. labels Nov 4, 2024
@jamesbt365
Copy link
Member

This is a breaking change, please rebase to next.

@BigBadE
Copy link
Author

BigBadE commented Nov 14, 2024

Already fixed on next, I just didn't see it:
https://github.com/Serenity-rs/serenity/blob/next/src/http/client.rs#L2665
Found the fix in
ec34676
guess I just didn't see the original issue because I was searching for the specific method name.

@BigBadE BigBadE closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
http Related to the `http` module. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_archived_public_threads and get_archived_private_threads use a u64 before instead of a timestamp
2 participants
@BigBadE @jamesbt365